Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105463
MIME-Version: 1.0
References: <CAF+90c-dXndgoPr6GfYsY3gudD3wEhL7YVx=pR=5SUjo2_7_WA@mail.gmail.com>
 <CAJd4=YZaNa7J62Aj+933s61-CzJ0AV94vmeyjiYwRK0ioQiZBA@mail.gmail.com>
In-Reply-To: <CAJd4=YZaNa7J62Aj+933s61-CzJ0AV94vmeyjiYwRK0ioQiZBA@mail.gmail.com>
Date: Fri, 26 Apr 2019 15:56:55 +0200
Message-ID: <CAF+90c_AMb9yh=B3D76eT3SV2+3DnvA_yvxCSvJv+9w8bkgOFw@mail.gmail.com>
To: =?UTF-8?Q?Pedro_Magalh=C3=A3es?= <mail@pmmaga.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000ab685605876f4fa3"
Subject: Re: [PHP-DEV] Alternative approach to short tags deprecation
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000ab685605876f4fa3
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 26, 2019 at 3:51 PM Pedro Magalh=C3=A3es <mail@pmmaga.net> wrot=
e:

> On Thu, Apr 25, 2019 at 8:15 AM Nikita Popov <nikita.ppv@gmail.com> wrote=
:
>
>> Any website using short_open_tags without explicitly
>> enabling it (relying on the default) will leak source code unless proper
>> precautions are taken before switching to PHP 7.4.
>>
>> In PHP 7.4:
>>  * The default value of short_open_tag remains as is and enabling
>> short_open_tag does not generate a deprecation warning (otherwise PHP
>> would
>> warn in a default config).
>>
>
> Hi! Thanks for providing an alternative to solve this. But I'd say to
> generate the deprecation notice on first use of the short tag both when t=
he
> user is relying on the default and when explicitly enabled. Although it m=
ay
> be annoying that we are throwing that notice on default config, it's the
> only way to warn everyone who would be affected when the default changes =
or
> the option is removed. I'd prefer to be annoyed than the alternative.
> Also, given that the notice will go away once you got rid of all your
> usages of the short tag, it sounds manageable to me.
>

Yes, usage of <? should throw a deprecation warning regardless of whether
short_open_tag is enabled by default or explicitly. What I meant here is
that enabling short_open_tag does not throw a deprecation *by itself*, only
the actual use of <? generates a deprecation.

Nikita

--000000000000ab685605876f4fa3--