Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105462
MIME-Version: 1.0
References: <CAF+90c-dXndgoPr6GfYsY3gudD3wEhL7YVx=pR=5SUjo2_7_WA@mail.gmail.com>
In-Reply-To: <CAF+90c-dXndgoPr6GfYsY3gudD3wEhL7YVx=pR=5SUjo2_7_WA@mail.gmail.com>
Date: Fri, 26 Apr 2019 14:50:48 +0100
Message-ID: <CAJd4=YZaNa7J62Aj+933s61-CzJ0AV94vmeyjiYwRK0ioQiZBA@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000008accaf05876f3987"
Subject: Re: [PHP-DEV] Alternative approach to short tags deprecation
From: mail@pmmaga.net (=?UTF-8?Q?Pedro_Magalh=C3=A3es?=)

--0000000000008accaf05876f3987
Content-Type: text/plain; charset="UTF-8"

On Thu, Apr 25, 2019 at 8:15 AM Nikita Popov <nikita.ppv@gmail.com> wrote:

> Any website using short_open_tags without explicitly
> enabling it (relying on the default) will leak source code unless proper
> precautions are taken before switching to PHP 7.4.
>
> In PHP 7.4:
>  * The default value of short_open_tag remains as is and enabling
> short_open_tag does not generate a deprecation warning (otherwise PHP would
> warn in a default config).
>

Hi! Thanks for providing an alternative to solve this. But I'd say to
generate the deprecation notice on first use of the short tag both when the
user is relying on the default and when explicitly enabled. Although it may
be annoying that we are throwing that notice on default config, it's the
only way to warn everyone who would be affected when the default changes or
the option is removed. I'd prefer to be annoyed than the alternative.
Also, given that the notice will go away once you got rid of all your
usages of the short tag, it sounds manageable to me.

Regards,
Pedro

--0000000000008accaf05876f3987--