Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105461
Return-Path: <nikita.ppv@gmail.com>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 65117 invoked from network); 26 Apr 2019 16:13:50 -0000
Received: from unknown (HELO mail-io1-f44.google.com) (209.85.166.44)
  by pb1.pair.com with SMTP; 26 Apr 2019 16:13:50 -0000
Received: by mail-io1-f44.google.com with SMTP id p23so2853438iol.13
        for <internals@lists.php.net>; Fri, 26 Apr 2019 06:14:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=+Ddv0tT317sL+rWx1MPGoCoAWPoVq+R1Nl9yI4KtS6o=;
        b=gkF+flBalWA42pKwkmgeHeG39FmavPhV+CvEK/OhIWaskGpn6lFovMxSJMVesk0LN1
         j6qqYuCyTjkUA22KENT/9fKrpQb3mTsnT4NAABHdhTxuAXYNM1ob5JDUhXCkCcN5i/cp
         uAhRLljBYVEX6KJ1meYaaE4ltstCCi1txhxi7I6/YOCZ0QtV6j8EVi2Tr3wMLBHJuele
         U+SRlWTFnS5tR0wiRkRJkR064YGL9vsGjkxSah9yJW2a7EmZMY2BS1Ga3rGUERRlz0m7
         H1nVDJ6zuKjOQtoMaLqmXAPJYz9PVEbKuUMmjjvCsdZoqXwT6Nl9u7g6AJCo8p9XP4A0
         qWkg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=+Ddv0tT317sL+rWx1MPGoCoAWPoVq+R1Nl9yI4KtS6o=;
        b=MZN1TzFpDjiXnaCkfaSVZorU3Ydeo5X2LsCiC4npIql4JrKD7XnW2TDXvh/sHfTH5c
         iwaTqnJ9mRHRVoFZLiPCs1Qjt+eHtRCpsxk4nplCC/VQ6D7AVg7/1L2ms5sM0i1qN0qI
         n91EBWhoV7W+Mtbv0X+UyYRADPz32CxC19UagqY3QGni/aKwZwH5BWjZqWnFb9GF2MUX
         Te1ZGd+Zk8l9DuiSiEPjjEACd8Hy22lm/uryLb07jYyYSvbGWF7MKTaq+tlWU29zVMug
         N4//aXvndllFtlswBmcCIHRH9GfA+oAxozHgsGXPw9Be1PJtaPovyoQ2Z4F1b0ohc5pA
         pyBw==
X-Gm-Message-State: APjAAAX4Bb/TDNx5D4ls+owrvx+/VcUjHin1McvzNL8/ZpwGIZWehgXF
	QYZjJ3IVPK/w28uf3aUBLdAO2pQiwx6dBxD+y/Q=
X-Google-Smtp-Source: APXvYqyCj4c4PLsFidIlR18LTnxsVtydoxmIV5dfxS9YlEFrBtgjavalbJeWrgYZGIDQ8Fww7FkPffgNyu9KXroB5Nc=
X-Received: by 2002:a6b:bdc4:: with SMTP id n187mr4976478iof.47.1556284498428;
 Fri, 26 Apr 2019 06:14:58 -0700 (PDT)
MIME-Version: 1.0
References: <5c633ed8.1c69fb81.143ab.ad85@mx.google.com> <CAEQoxLLncOfiSvB23=yTOF8D5D0Ba=YC96eqP0XWJXAz5xw6Yg@mail.gmail.com>
 <CAG9XoMT1WFLKMjC1o6mPkvv4zPu1D+6NpgP9VYx4ppYocjRmjw@mail.gmail.com>
 <CAEQoxLL8a6DhyDmEdBbNUfGCqy04UeLAK6HQO=zYrVbGG2w40w@mail.gmail.com>
 <CAG9XoMQkZYP9wNNu0tQYTcuWJPx=4u7NfSdPCQDjo7O3o02OxA@mail.gmail.com>
 <6a97cecf-7a5d-6476-7773-fdd41aa45646@gmx.de> <CAG9XoMStfqmDqjQ7SMSZXEbvXvSAh_YwstjF67+nSumCh_5s4A@mail.gmail.com>
 <CAEQoxLLxB715OSUkM8OYs+3z9E8kLe45zrEh5sT7gx00r1waZA@mail.gmail.com> <CAG9XoMSWub7GhmMhiwmhdXN7v+nubzkmtyJm7r8Gq3FzVDr4rA@mail.gmail.com>
In-Reply-To: <CAG9XoMSWub7GhmMhiwmhdXN7v+nubzkmtyJm7r8Gq3FzVDr4rA@mail.gmail.com>
Date: Fri, 26 Apr 2019 15:14:41 +0200
Message-ID: <CAF+90c9sWw9=kP16_yKxvzw-j=gY69foVfXt3S4O=OzUWyqbQQ@mail.gmail.com>
To: Benjamin Morel <benjamin.morel@gmail.com>
Cc: Vladyslav Startsev <vladyslavstartsev@gmail.com>, "Christoph M. Becker" <cmbecker69@gmx.de>, 
	"Legale.legale" <legale.legale@gmail.com>, Ben Ramsey <ben@benramsey.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000b2ca4c05876eb8ca"
Subject: Re: [PHP-DEV] Make bcmath functions more strict
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000b2ca4c05876eb8ca
Content-Type: text/plain; charset="UTF-8"

On Fri, Apr 26, 2019 at 3:10 PM Benjamin Morel <benjamin.morel@gmail.com>
wrote:

> > Yes, PHP 8 for BCs and PHP 7.4 for warnings that's what I was trying to
> said
>
> FWIW, I don't think anyone will complain about adding a warning to
> something that's obviously a bug when it fails.
> I'd say go ahead a write an RFC. If you want to have more chances for it to
> pass though, I would not change the semantics of the current conversions
> from string to decimal (what's considered a valid decimal number and what's
> not). I would just propose to add a warning when an argument is converted
> to zero because it is *currently* considered malformed.
>
> - Ben
>

Feel free to just send a PR that implements the warning. We don't really
need an RFC for such a minor and straightforward change.

Nikita

--000000000000b2ca4c05876eb8ca--