Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105454
Return-Path: <benjamin.morel@gmail.com>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 79575 invoked from network); 26 Apr 2019 10:45:05 -0000
Received: from unknown (HELO mail-it1-f182.google.com) (209.85.166.182)
  by pb1.pair.com with SMTP; 26 Apr 2019 10:45:05 -0000
Received: by mail-it1-f182.google.com with SMTP id s3so4448708itk.1
        for <internals@lists.php.net>; Fri, 26 Apr 2019 00:46:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=9Z97/DAMsEwGopvmw+LFPiqnKTNGu4RW5mSGYxgW9rQ=;
        b=REHF83iVMoqXQlonTL62OdT8zVNfb8iq87WbNnpfpDeP0XOBev6RHKK1LWA4mEPpKW
         0zaAoevkJabVWFfny1FUuJgwikipxdbp1jiwqjkXaRa5jP/t/kg/EvyEVOqEUrToSQJe
         dTooxQeiar4dncKYog7NBWV9SYncPQYiR+O19H8aqNbNMmyTkNpBbeiJGTnk3NhFwe08
         DTAOmKdopBdKb/6U516VCxdpz1z22qQqDLyRFyDW3ieV/1+WLqjje+mhPvm8VGGX170a
         0awy3uY2pHwNlxL3oNQI9idR52JwdYqKyVD0NB+MG7r7ge3vOlzIKADzvWx0baIkwRgI
         +U7A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=9Z97/DAMsEwGopvmw+LFPiqnKTNGu4RW5mSGYxgW9rQ=;
        b=V0lusqUkRwEeYzGykzRUYbkmf4n7eoHE22WJ+4945tn0dJ7Q2bavLtYs/UatExghmd
         vAr93PlCjTEOqQ1hNMwtIJGdkDe/0XIh8lcG7WqXpVG/vzWLBsHW78K4SAnPK7lYFO0i
         5awP62wPJ5nQdeLmGQwtMWJ6TA/BgIXFjC+gMwZAd/1L/Dw6dqxVQPv34in7C/Dfa5DH
         MbQVdapzHSyhGQESmGKhU8k+4uwf9U/gOIqK3ddkplIa7crL3XpDkTcx0flVyKo7693M
         Umxvu3tEcM+884xVef69Fbxo+ue6D5PhXj3nsYnAkV2Z/F1DCUaEk1yfAORKgLpvyUaV
         FsMQ==
X-Gm-Message-State: APjAAAWt5nhzzRMqKkLsa3syTb+TfQa4ZCMdmgCjUzSBh/7vC5zovJ4x
	4O846lzTV1zldQUFhkrcH44JZuoxKKmMdEWj6zE=
X-Google-Smtp-Source: APXvYqymcWKJXGUm6DemcXLi8QVazlxh0Grv2VFfD+hOLRAb1cNSD8BAbjO2NefhpQ3Ewznme8PpsGEeeiFrXkHJQyU=
X-Received: by 2002:a24:6e01:: with SMTP id w1mr7747642itc.15.1556264770267;
 Fri, 26 Apr 2019 00:46:10 -0700 (PDT)
MIME-Version: 1.0
References: <5c633ed8.1c69fb81.143ab.ad85@mx.google.com> <CAEQoxLLncOfiSvB23=yTOF8D5D0Ba=YC96eqP0XWJXAz5xw6Yg@mail.gmail.com>
 <CAG9XoMT1WFLKMjC1o6mPkvv4zPu1D+6NpgP9VYx4ppYocjRmjw@mail.gmail.com> <CAEQoxLL8a6DhyDmEdBbNUfGCqy04UeLAK6HQO=zYrVbGG2w40w@mail.gmail.com>
In-Reply-To: <CAEQoxLL8a6DhyDmEdBbNUfGCqy04UeLAK6HQO=zYrVbGG2w40w@mail.gmail.com>
Date: Fri, 26 Apr 2019 09:45:56 +0200
Message-ID: <CAG9XoMQkZYP9wNNu0tQYTcuWJPx=4u7NfSdPCQDjo7O3o02OxA@mail.gmail.com>
To: Vladyslav Startsev <vladyslavstartsev@gmail.com>
Cc: "Legale.legale" <legale.legale@gmail.com>, Ben Ramsey <ben@benramsey.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000cef06b05876a207a"
Subject: Re: [PHP-DEV] Make bcmath functions more strict
From: benjamin.morel@gmail.com (Benjamin Morel)

--000000000000cef06b05876a207a
Content-Type: text/plain; charset="UTF-8"

Hi Vladyslav,

> I don't really understand it, I must be strict, converting to zero
> will lead to wrong calculations.

That's what I said :) Fully agree here, any non-numeric string should throw
an exception.

In summary, I would check that the string matches `
/^[\+\-]?[0-9]+(\.[0-9]+)?$/`or else throw an exception.

- Ben

--000000000000cef06b05876a207a--