Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105441
MIME-Version: 1.0
References: <5c633ed8.1c69fb81.143ab.ad85@mx.google.com> <CAEQoxLLncOfiSvB23=yTOF8D5D0Ba=YC96eqP0XWJXAz5xw6Yg@mail.gmail.com>
In-Reply-To: <CAEQoxLLncOfiSvB23=yTOF8D5D0Ba=YC96eqP0XWJXAz5xw6Yg@mail.gmail.com>
Date: Thu, 25 Apr 2019 11:35:24 +0200
Message-ID: <CAG9XoMT1WFLKMjC1o6mPkvv4zPu1D+6NpgP9VYx4ppYocjRmjw@mail.gmail.com>
To: Vladyslav Startsev <vladyslavstartsev@gmail.com>
Cc: "Legale.legale" <legale.legale@gmail.com>, Ben Ramsey <ben@benramsey.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000639adc0587578a16"
Subject: Re: [PHP-DEV] Make bcmath functions more strict
From: benjamin.morel@gmail.com (Benjamin Morel)

--000000000000639adc0587578a16
Content-Type: text/plain; charset="UTF-8"

Hi Vladyslav,

I just checked your code snippet, here are my 2 cents:

- bcmath should definitely trigger an error when encountering a malformed
string like '17 .123', silently converting it to zero is indeed the worth
thing to do;
- I don't think that there's much value in having it handle exponential
notation, you can use userland libraries such as brick/math
<https://github.com/brick/math> for this;
- I *really* don't think that it should depend on the current locale, like
PHP sometimes does with numbers; there has been some discussion just a few
months ago to actually stop making float-to-string conversion depend on
locale:
  https://externals.io/message/103638

Ben

On Thu, 25 Apr 2019 at 11:02, Vladyslav Startsev <
vladyslavstartsev@gmail.com> wrote:

> Any other ideas on that one?
>
> I'll wait for one more week and make RFC then
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--000000000000639adc0587578a16--