Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:105437 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 53041 invoked from network); 25 Apr 2019 11:21:10 -0000 Received: from unknown (HELO 28.ip-149-56-142.net) (149.56.142.28) by pb1.pair.com with SMTP; 25 Apr 2019 11:21:10 -0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: thruska@cubiclesoft.com) with ESMTPSA id 26A763EA5E To: =?UTF-8?Q?C=c3=b4me_Chilliet?= , internals@lists.php.net References: <2122186.CDTRH7ZZW5@mcmic-probook> Message-ID: <04485495-1cec-cec0-ffc1-3fe56b5f215c@cubiclesoft.com> Date: Thu, 25 Apr 2019 01:21:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 In-Reply-To: <2122186.CDTRH7ZZW5@mcmic-probook> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags From: thruska@cubiclesoft.com (Thomas Hruska) On 4/25/2019 12:57 AM, Côme Chilliet wrote: > Le jeudi 25 avril 2019, 00:11:42 CEST Thomas Hruska a écrit : >> So I built a tool that meets the above minimum criteria and have already >> run it against a fairly extensive codebase (and have shared the tool >> with a few concerned folks - you've already seen its output here on-list): >> >> https://github.com/cubiclesoft/php-short-open-tag-finder/ > > «// (C) 2019 CubicleSoft. All Rights Reserved.» does not meet my minimum criteria. From the README: * Has a liberal open source license. MIT or LGPL, your choice. Not sure what the problem is here. >> Tools that just walk down a directory tree and bulk >> modify by default, […] should all be rejected from >> consideration. > > I do not understand why you have a problem with this, the rest of your email seems to suggest you are using git. > Just run the tool and then look at the diff before committing anything. > > This makes *way* more sense than having to manually review each change one by one. I err on the side of caution for a variety of reasons that are off-topic for this list/thread. -- Thomas Hruska CubicleSoft President I've got great, time saving software that you will find useful. http://cubiclesoft.com/ And once you find my software useful: http://cubiclesoft.com/donate/