Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:105436 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 47314 invoked from network); 25 Apr 2019 11:05:30 -0000 Received: from unknown (HELO 28.ip-149-56-142.net) (149.56.142.28) by pb1.pair.com with SMTP; 25 Apr 2019 11:05:30 -0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: thruska@cubiclesoft.com) with ESMTPSA id 197E33EA5E To: Stephen Reay , PHP Development References: <0ec42fa9-77d1-a203-8425-e72fdd5071f3@korulczyk.pl> <06473788-a34b-f041-36e6-31d19d8dda4c@cubiclesoft.com> <59cafbfb-2bb0-468c-458f-74bcac780e0f@korulczyk.pl> <004c01d4f09f$880ac320$98204960$@roze.lv> <2C69874F-400D-404E-B788-B3A24D599785@koalephant.com> Message-ID: <97ab8703-fc68-2889-db4b-98d5df5c4bd7@cubiclesoft.com> Date: Thu, 25 Apr 2019 01:06:17 -0700 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 In-Reply-To: <2C69874F-400D-404E-B788-B3A24D599785@koalephant.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags From: thruska@cubiclesoft.com (Thomas Hruska) On 4/25/2019 12:26 AM, Stephen Reay wrote: > >> On 25 Apr 2019, at 14:11, Thomas Hruska wrote: >> sed-based solutions do NOT work. >> Neither of the two recommended options to date on this list are valid recommendations for serious software deployment managers. > > > I have no issue with suggesting tools to fix short opening tags, but lay off the absolute statements. > > The approaches mentioned literally do work (because the people who mentioned them used them), they just may not work *for your codebase*. Both the sed and PHP-CS-Fixer solutions recommended on this list would have broken several of my production applications AND failed to provide a complete conversion in the process. Hopefully that explains where my statement came from. Apologies if I came on too strongly here. I still think that software that works only on a subset of PHP code is a recipe for disaster. -- Thomas Hruska CubicleSoft President I've got great, time saving software that you will find useful. http://cubiclesoft.com/ And once you find my software useful: http://cubiclesoft.com/donate/