Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:105400 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 86355 invoked from network); 24 Apr 2019 20:43:30 -0000 Received: from unknown (HELO mail-lf1-f52.google.com) (209.85.167.52) by pb1.pair.com with SMTP; 24 Apr 2019 20:43:30 -0000 Received: by mail-lf1-f52.google.com with SMTP id t30so15349317lfd.8 for ; Wed, 24 Apr 2019 10:44:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EIp2Gp2qd/I7OPAcNkQbi++GFeAb4ztdcuTZz0gi9vM=; b=vAuAsBNHDOt4HiOc9ChIbU4B/dU4TKzLuh9ig6idMBaNnmVwvK1Tpes6xG6UiRBupo 82XqrEjt2FFvN5H6cQofSpnAIsFDvjZK8QQDsilUvkRO14YlD2H1JVGmvrcvcyJAO410 YYq9/7RKXqVqZnaisC1AoMl4aDoRdMFdRqJHQnTlNn00PpHPl3MYMpkouUPxojQ2kJ/f x2aRStPobGu9l9qXizvNx33kVV+zH51Ws1M+byOW51mCOC3ZQ0spl8XJOC7/Hl4Q6P6e L5JMU53mzjDNVuGkSRBM6esus+4o06rDGhDoRgvUQNK8h5JCIsnH2OxyJcDEV+wIyKay Rayw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EIp2Gp2qd/I7OPAcNkQbi++GFeAb4ztdcuTZz0gi9vM=; b=JuTDu3S+jajBcjAIGlP2XhL0W4q6ZIPLrs40ZIfzlefQhzG9FitaXJ7KjrwpHF1egq OI1ok0f7FeM3mc6xqtWct35+z0ETMGijbYj9EXz6YtNxCLwIsdye9OhaYRNtzU7BxKOp Z5oQ/NAIepM50StwUFKIMjd1T033AY9bjYbOwB8CYHkUh/KOpBPX1fATBCuVdos5m+9I a26g1tuyT2NkLIgxwESKP5jGV+W4ZgBB5mTICnAn3HYHFXAGoc9JPtpi06aOlasj3kUF JzYFUDWRlYAztsAwRbfJWZy/APNx8iwzfv1cJTAZCgEKuDuSdmKv3GrcqCFEmq/0J0a7 aaCw== X-Gm-Message-State: APjAAAVO2oSwRvmwkB/qe8pVCshcPMJayVZsd58kbrI3LZmwPpt84iYJ 0cJT6nSxFLl//k41bIVfyUG4wP7iLtPJq9ol1P8= X-Google-Smtp-Source: APXvYqylP9FTzwTpVwN+oRx4Mdg+KjRKdt+nB/V2HR8c3qLTlkLINjp2duhBCxwNlxqxrcpcL+2G+ConeX4gGP2ScUg= X-Received: by 2002:a19:20c8:: with SMTP id g191mr19163415lfg.122.1556127850957; Wed, 24 Apr 2019 10:44:10 -0700 (PDT) MIME-Version: 1.0 References: <0ec42fa9-77d1-a203-8425-e72fdd5071f3@korulczyk.pl> <06473788-a34b-f041-36e6-31d19d8dda4c@cubiclesoft.com> <59cafbfb-2bb0-468c-458f-74bcac780e0f@korulczyk.pl> <004c01d4f09f$880ac320$98204960$@roze.lv> <004401d4faa3$60f83700$22e8a500$@gmail.com> <2f922f17-bc7c-313a-8f77-122e861995be@lsces.co.uk> <5741936F-B1F4-43C7-B815-F9D8030AC7BB@koalephant.com> <49A4B76C-4C62-4CBE-BA20-FBE56CA29AB0@cschneid.com> <609E93CF-099B-446C-AD28-04F1D802C9F0@cschneid.com> In-Reply-To: Date: Wed, 24 Apr 2019 13:43:59 -0400 Message-ID: To: Marco Pivetta Cc: Christian Schneider , Peter Kokot , PHP Internals List Content-Type: multipart/alternative; boundary="000000000000c8105405874a3ff0" Subject: Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags From: chasepeeler@gmail.com (Chase Peeler) --000000000000c8105405874a3ff0 Content-Type: text/plain; charset="UTF-8" On Wed, Apr 24, 2019 at 1:27 PM Marco Pivetta wrote: > On Wed, 24 Apr 2019, 19:25 Christian Schneider, > wrote: > > > Am 24.04.2019 um 19:13 schrieb Marco Pivetta : > > > On Wed, 24 Apr 2019, 19:10 Christian Schneider, > > > wrote: > > > Am 24.04.2019 um 19:01 schrieb Peter Kokot : > > > > just a friendly reminder that by the time one writes an email here > > > > these tags can be already replaced with the usual ones. > > > > > > A friendly reminder that some people are hosting customer code which > > they do not want to touch but will get support requests once the code > > breaks. > > > > > > - Chris > > > > > > That's normal? Everyone has projects to maintain, and breaking changes > > are common: they're gonna call you for one anyway: if you don't like > that, > > then you are in the wrong line of business. > > > > See Chase Peeler's point: A breaking change should have a reward big > > enough to justify it. > > And that's what where we (including Zeev Suraski and other core > > developers) disagree. > > > > - Chris > > > > Run a fixer: they are out there, and they are extremely stable too. > > Also a good chance to finally take a look at code that has been rotting in > a hard drive for too much time. > All of that takes time though. I have 6,787 short opening tags found. Even if I use a fixer to generate a diff, or, to fix them and then examine the diff in a pull request... that's going to take a LOT of time. It's going to start getting messy if I find false positives and need to exclude changes. It still doesn't address the impact of changes that aren't found. Are you 100% positive that the fixers out there will catch EVERY single instance? php-cs-fixer doesn't update