Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105391
Return-Path: <markyr@gmail.com>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 56675 invoked from network); 24 Apr 2019 19:34:52 -0000
Received: from unknown (HELO localhost.localdomain) (76.75.200.58)
  by pb1.pair.com with SMTP; 24 Apr 2019 19:34:52 -0000
To: internals@lists.php.net
References: <CAFPFaMJEn=gjk5jAAxR2bF=4Mt3r0FJCm6mbOCReOmyybtAkkg@mail.gmail.com>
 <CAOv67gsiva80KEhw7D2N2qKCz0gZvza30EDL7SZoJRPFsGoROA@mail.gmail.com>
 <0ec42fa9-77d1-a203-8425-e72fdd5071f3@korulczyk.pl>
 <06473788-a34b-f041-36e6-31d19d8dda4c@cubiclesoft.com>
 <59cafbfb-2bb0-468c-458f-74bcac780e0f@korulczyk.pl>
 <004c01d4f09f$880ac320$98204960$@roze.lv>
 <CAFPFaM+QwXpm-mfwRtbT2sPB_C-9wvPELVTV5dHvizgmfUjMnw@mail.gmail.com>
 <004401d4faa3$60f83700$22e8a500$@gmail.com>
 <2f922f17-bc7c-313a-8f77-122e861995be@lsces.co.uk>
 <CAPKYkKyS4A_zQO3OEqqv+LOrG5cPLjGqUEXonsQeA_jcE=69Gg@mail.gmail.com>
 <5cc08999.1c69fb81.9fdc4.30ccSMTPIN_ADDED_MISSING@mx.google.com>
 <CAPKYkKzYBfnfY6PKtvk5rfL9GBChCoq0MXOpt4tr9rtDcDUqVQ@mail.gmail.com>
Date: Wed, 24 Apr 2019 17:35:33 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <CAPKYkKzYBfnfY6PKtvk5rfL9GBChCoq0MXOpt4tr9rtDcDUqVQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Posted-By: 94.0.205.114
Subject: Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags
From: markyr@gmail.com (Mark Randall)
Message-ID: <php.internals-105391@news.php.net>

On 24/04/2019 17:14, Chase Peeler wrote:
>> As I've mentioned in other posts, I don't trust this to do a blind
> find/replace. Some of our legacy code files are REALLY bad. Just doing auto
> formatting on them in PhpStorm will break things.

I believe you may be misinterpreting how these tools work. It's not a 
text based find / replace.

Instead, each PHP file is being fully tokenised just as the PHP parser 
would (in some cases, it is the PHP parser itself doing it) and then the 
short tags are being replaced, and the file reassembled.

The only points you would have to be wary of would be if you were 
computer-generating code, as it would not pick up <? used inside string 
literals.

--
Mark Randall