Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:105381 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 25773 invoked from network); 24 Apr 2019 18:27:11 -0000 Received: from unknown (HELO mail1.25mail.st) (206.123.115.54) by pb1.pair.com with SMTP; 24 Apr 2019 18:27:11 -0000 Received: from [10.0.1.90] (unknown [49.48.243.98]) by mail1.25mail.st (Postfix) with ESMTPSA id 4C57660553; Wed, 24 Apr 2019 15:27:41 +0000 (UTC) Message-ID: <301BACB1-86FF-4315-9D99-D17A2FDC7F27@koalephant.com> Content-Type: multipart/alternative; boundary="Apple-Mail=_DB097EAF-A256-4E89-814B-C6EEBFBAFEB5" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Date: Wed, 24 Apr 2019 22:27:39 +0700 In-Reply-To: Cc: Lester Caine , PHP internals To: Chase Peeler References: <0ec42fa9-77d1-a203-8425-e72fdd5071f3@korulczyk.pl> <06473788-a34b-f041-36e6-31d19d8dda4c@cubiclesoft.com> <59cafbfb-2bb0-468c-458f-74bcac780e0f@korulczyk.pl> <004c01d4f09f$880ac320$98204960$@roze.lv> <004401d4faa3$60f83700$22e8a500$@gmail.com> <2f922f17-bc7c-313a-8f77-122e861995be@lsces.co.uk> <38D18C20-F297-457A-8BF3-089FFDC8FB3B@koalephant.com> X-Mailer: Apple Mail (2.3445.104.8) Subject: Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags From: php-lists@koalephant.com (Stephen Reay) --Apple-Mail=_DB097EAF-A256-4E89-814B-C6EEBFBAFEB5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 24 Apr 2019, at 22:16, Chase Peeler wrote: >=20 >=20 >=20 > On Wed, Apr 24, 2019 at 11:02 AM Stephen Reay = > wrote: >=20 > > On 24 Apr 2019, at 21:35, Chase Peeler > wrote: > >=20 > > If I get started now, maybe I can have everything fixed by the time = 8.1 is > > released. >=20 >=20 > Two characters less than this sentence of yours is a 1-liner find/sed = script to replace all ` Would you really feel confident doing a blind find/replace on 6,000+ = instances? It=E2=80=99s hardly =E2=80=9Cblind=E2=80=9D. This is what version = control is for. You make a change, and then either view the diff = locally, and/or commit/push it, and ask others to help review the diff. I literally just ran the script referenced above on a client project, = eyeballed the diff, and committed the changes it made to a branch. Once = I=E2=80=99m not in the middle of anything I=E2=80=99ll review it again = and then merge it. >=20 > what about =20 > What if I utilize a 3rd party library that, while no longer support, = works fine, but is now broken for no other reason than the fact that =20 You do the same thing as if the library had a security issue or some = other bug. If it=E2=80=99s unsupported, you have to support it, or you = have to find a replacement. It=E2=80=99s not like you=E2=80=99re dealing = with a compiled module that you can=E2=80=99t edit. Run the same fix for = short tags on the library. > I don't trust mass find/replace tools like php-cs-fixer. Some of our = legacy code is really ugly. Auto-formatting with PhpStorm will break it. = I don't mind using an interactive tool, but that means I have to sit = there and hit Y or N for 6,787 instances. Some of them will probably = require me to actually open the file up and check out the surrounding = context as well. And, what happens if I miss one? I run the risk of code = leak. If auto formatting =E2=80=98breaks=E2=80=99 your code, you have a bigger = problem than short tags. >=20 > I think it's great that many of you have code bases that are in pretty = good shape and this change isn't going to have much of an impact on you. = That's not my case, though. It's not the case for a LOT of people. I'm = not against BC breaks - even major ones - if they are justified. I have = yet to see any good justifications for such a massive BC break.=20 >=20 > The fact is that this change WILL prevent a lot of people from being = able to upgrade to 8.0 in a timely manner. Anyone that has to justify = spending time to prepare for an upgrade to people that don't understand = the benefits of the upgrade will have an ever harder time trying to = justify the extra time necessary. I also think you are going to find a = good number of people that will upgrade (or use PHP for the first time) = unaware of the change. They'll attempt to load older code that has short = tags in it. It won't work. They'll say "screw it" and use python or = node.=20 > --=20 > Chase Peeler > chasepeeler@gmail.com --Apple-Mail=_DB097EAF-A256-4E89-814B-C6EEBFBAFEB5--