Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105380
MIME-Version: 1.0
References: <CAFPFaMJEn=gjk5jAAxR2bF=4Mt3r0FJCm6mbOCReOmyybtAkkg@mail.gmail.com>
 <CAOv67gsiva80KEhw7D2N2qKCz0gZvza30EDL7SZoJRPFsGoROA@mail.gmail.com>
 <0ec42fa9-77d1-a203-8425-e72fdd5071f3@korulczyk.pl> <06473788-a34b-f041-36e6-31d19d8dda4c@cubiclesoft.com>
 <59cafbfb-2bb0-468c-458f-74bcac780e0f@korulczyk.pl> <004c01d4f09f$880ac320$98204960$@roze.lv>
 <CAFPFaM+QwXpm-mfwRtbT2sPB_C-9wvPELVTV5dHvizgmfUjMnw@mail.gmail.com>
 <004401d4faa3$60f83700$22e8a500$@gmail.com> <2f922f17-bc7c-313a-8f77-122e861995be@lsces.co.uk>
 <CAPKYkKyS4A_zQO3OEqqv+LOrG5cPLjGqUEXonsQeA_jcE=69Gg@mail.gmail.com> <38D18C20-F297-457A-8BF3-089FFDC8FB3B@koalephant.com>
In-Reply-To: <38D18C20-F297-457A-8BF3-089FFDC8FB3B@koalephant.com>
Date: Wed, 24 Apr 2019 11:16:33 -0400
Message-ID: <CAPKYkKzmzE4EpZ7U0ifLME2NWxry5aiWGSNf_qY1vts952cTRA@mail.gmail.com>
To: Stephen Reay <php-lists@koalephant.com>
Cc: Lester Caine <lester@lsces.co.uk>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000008619fc05874830dc"
Subject: Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags
From: chasepeeler@gmail.com (Chase Peeler)

--0000000000008619fc05874830dc
Content-Type: text/plain; charset="UTF-8"

On Wed, Apr 24, 2019 at 11:02 AM Stephen Reay <php-lists@koalephant.com>
wrote:

>
> > On 24 Apr 2019, at 21:35, Chase Peeler <chasepeeler@gmail.com> wrote:
> >
> > If I get started now, maybe I can have everything fixed by the time 8.1
> is
> > released.
>
>
> Two characters less than this sentence of yours is a 1-liner find/sed
> script to replace all `<? ` with `<?php `.

Would you really feel confident doing a blind find/replace on 6,000+
instances?

what about <?if ... `<? ` wouldn't match that. I have instances of that in
my code, though.

What if I utilize a 3rd party library that, while no longer support, works
fine, but is now broken for no other reason than the fact that <? is no
longer supported? Whether I should be using that library or not is
irrelevant. The fact is, I am, and the fact that I won't be able to use it
in 8.0 is a barrier to me upgrading.

I don't trust mass find/replace tools like php-cs-fixer. Some of our legacy
code is really ugly. Auto-formatting with PhpStorm will break it. I don't
mind using an interactive tool, but that means I have to sit there and hit
Y or N for 6,787 instances. Some of them will probably require me to
actually open the file up and check out the surrounding context as well.
And, what happens if I miss one? I run the risk of code leak.

I think it's great that many of you have code bases that are in pretty good
shape and this change isn't going to have much of an impact on you. That's
not my case, though. It's not the case for a LOT of people. I'm not against
BC breaks - even major ones - if they are justified. I have yet to see any
good justifications for such a massive BC break.

The fact is that this change WILL prevent a lot of people from being able
to upgrade to 8.0 in a timely manner. Anyone that has to justify spending
time to prepare for an upgrade to people that don't understand the benefits
of the upgrade will have an ever harder time trying to justify the extra
time necessary. I also think you are going to find a good number of people
that will upgrade (or use PHP for the first time) unaware of the change.
They'll attempt to load older code that has short tags in it. It won't
work. They'll say "screw it" and use python or node.
-- 
Chase Peeler
chasepeeler@gmail.com

--0000000000008619fc05874830dc--