Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105237
MIME-Version: 1.0
References: <CAFPFaMJEn=gjk5jAAxR2bF=4Mt3r0FJCm6mbOCReOmyybtAkkg@mail.gmail.com>
 <CAPg3XxL2GESpYiH+-NmhT28r_CTutA=Yh87Z9+JdAtLrszktWQ@mail.gmail.com>
In-Reply-To: <CAPg3XxL2GESpYiH+-NmhT28r_CTutA=Yh87Z9+JdAtLrszktWQ@mail.gmail.com>
Date: Thu, 11 Apr 2019 12:27:48 +0200
Message-ID: <CAFPFaMJMJVsoSCYfryw_4TfM5uiWzYhyeEzG5aMWPVtEATjjCw@mail.gmail.com>
To: Peter Cowburn <petercowburn@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000003bb4905863ea534"
Subject: Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags
From: george.banyard@gmail.com ("G. P. B.")

--00000000000003bb4905863ea534
Content-Type: text/plain; charset="UTF-8"

On Thu, 11 Apr 2019 at 12:14, Peter Cowburn <petercowburn@gmail.com> wrote:

>
>
> On Wed, 10 Apr 2019 at 11:44, G. P. B. <george.banyard@gmail.com> wrote:
>
>> Hello Internals,
>>
>> As there have been no further comments the voting for my RFC [1] to
>> deprecate PHP's
>> short open tags has started and will run for two (2) weeks.
>>
>
> Firstly, I apologize for not mentioning this before the vote was opened.
>
> Does the primary (it's probably not fair to call it that, for this RFC)
> vote include changing the default (php -n) from On to Off? That's what is
> specified in the very concise proposal section, so it seems reasonable to
> assume it's the case, but I just want to be sure since the actual vote
> question doesn't mention changing the default value.
>
> With the current state of voting, it is looking like we could end up such
> that we don't deprecate (and disable by default, maybe) the feature, but
> jump straight to removing it.  That's not usually how feature removal
> works.  It would've been better, IMO, to just take the proposal
> ("Deprecate and disable short_open_tag in PHP 7.4 and remove PHP's short
> open tags in PHP 8.0.") and make that a yes/no vote.
>

Hello Peter,

For changing the default from On to Off it more something I realised during
the implementation of the patch that the in-engine default is "On",
which I found to be unexpected (probably because the doc says it's only
enabled with a compile flag) so I changed it.
But the default could stay the same as I'm starting to realise that with
current state of voting we are getting kind of a mess of a split vote as
you said.

It would have been nice that someone would have noticed the problems with
the voting structure before I start it but not to sure how to proceed.
I don't know if people vote against the deprecation notice in PHP 7.4 as
the default value changes because if this is the case maybe leaving the
default
as is and only deprecating would be better?

Also I do agree that having deprecation notices before a feature removal is
wise but from my understanding the RFC which removed the ASP tags also
didn't have deprecation notices, so there is already a precedent for
removing features without warning (not that I agree with it).

So not sure how to proceed ATM and some more feedback would be probably
necessary as it is my first RFC.

Best regards

George P. Banyard

--00000000000003bb4905863ea534--