Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105162
MIME-Version: 1.0
References: <CAF+90c_Xcz6rTq_CdAFdGBhW2eLDZOVEkLRgKgJZTwRQSsTTBA@mail.gmail.com>
In-Reply-To: <CAF+90c_Xcz6rTq_CdAFdGBhW2eLDZOVEkLRgKgJZTwRQSsTTBA@mail.gmail.com>
Reply-To: bishop@php.net
Date: Tue, 9 Apr 2019 05:39:54 -0400
Message-ID: <CAEYWF=4Jbm+fz1wPQSATOWB3M+OJHMpkFYZR5_27hwf7AJSJEg@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000bcff51058615bdcf"
Subject: Re: [PHP-DEV] [RFC] Always generate fatal error for incompatible
 method signatures
From: bishop@php.net (Bishop Bettini)

--000000000000bcff51058615bdcf
Content-Type: text/plain; charset="UTF-8"

On Tue, Apr 9, 2019 at 4:25 AM Nikita Popov <nikita.ppv@gmail.com> wrote:

> Hi internals,
>
> A small cleanup RFC for PHP 8: https://wiki.php.net/rfc/lsp_errors
>
> This makes all incompatible method signature (LSP) errors fatal, rather
> than only warning in some cases. Especially after
> https://wiki.php.net/rfc/parameter-no-type-variance I don't think there's
> any reason to keep this backdoor in place.
>

Thank you, Nikita.

+1 from me. This inconsistency was a personal WTF moment, 3 years ago:
https://stackoverflow.com/q/37889466/2908724

On Tue, Apr 9, 2019 at 4:25 AM Nikita Popov <nikita.ppv@gmail.com> wrote:

> Hi internals,
>
> A small cleanup RFC for PHP 8: https://wiki.php.net/rfc/lsp_errors
>
> This makes all incompatible method signature (LSP) errors fatal, rather
> than only warning in some cases. Especially after
> https://wiki.php.net/rfc/parameter-no-type-variance I don't think there's
> any reason to keep this backdoor in place.
>
> Regards,
> Nikita
>

--000000000000bcff51058615bdcf--