Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105145
MIME-Version: 1.0
References: <003a01d4eaf0$c17d6c20$44784460$@jhdxr.com>
In-Reply-To: <003a01d4eaf0$c17d6c20$44784460$@jhdxr.com>
Date: Mon, 8 Apr 2019 15:21:41 +0200
Message-ID: <CAF+90c9SG=+YbFEBcTYOpS7VNpYGk1AogCecXg_s6RYPaW=NuQ@mail.gmail.com>
To: CHU Zhaowei <me@jhdxr.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000a76613058604b88c"
Subject: Re: [PHP-DEV] [RFC] Spread Operator in Array Expression v0.2
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000a76613058604b88c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 4, 2019 at 4:15 PM CHU Zhaowei <me@jhdxr.com> wrote:

> Hi internals,
>
> Thanks for the people who joined the discussion of my [RFC: Spread
> Operator in Array Expression](
> https://wiki.php.net/rfc/spread_operator_for_array). The biggest change
> is I have dropped the support for string keys in v0.2 as suggested by C=
=C3=B4me,
> to make the behavior of spread operator consistent. I have also added Q&A
> to explain the questions I received.
>

This looks reasonable to me. My only concern would be the "by-reference
passing" section of the RFC. The current proposal states that [...$arr]
will preserve references in $arr, which is not the behavior I would expect.

Is this choice for parity with the unpacking functionality in calls? In
that case I think it is important to understand that for argument unpacking
the handling of references is decided by the called function, not what is
in the array. If the function accepts an argument by-reference, then the
corresponding element in the array will be turned into a reference
(regardless of whether it was one before). Conversely, if the function
accepts an argument by-value, then the element from the array will be
passed by-value (regardless of whether it was a reference before). A
similar concept doesn't really exist for unpacking in arrays.

Regards,
Nikita

--000000000000a76613058604b88c--