Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:104984
Return-Path: <wikimedia@cscott.net>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 94873 invoked from network); 29 Mar 2019 00:44:56 -0000
Received: from unknown (HELO mail-ot1-f54.google.com) (209.85.210.54)
  by pb1.pair.com with SMTP; 29 Mar 2019 00:44:56 -0000
Received: by mail-ot1-f54.google.com with SMTP id d24so119859otl.11
        for <internals@lists.php.net>; Thu, 28 Mar 2019 14:38:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=wikimedia.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=ljf5wVTDAbKRMMMFxZfo2MJlr/WwEsBOLOQKU+BD7aA=;
        b=c9oW/6zUsBqeEM9bhASXmO30/kxyaCrwjoFSjhzte8WwxEwlo4DaNfBK5mzuW3qIN1
         dvF0Dqs/eLxEqO2k+Bu/aPOmGf4KnSdaMugx1Ux6Ns0/HlILUQPYSVmWlxSCcM4unkcN
         hELGOtqkFbtPnZuISRoBfNRSLItBuwxYeT1gA=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=ljf5wVTDAbKRMMMFxZfo2MJlr/WwEsBOLOQKU+BD7aA=;
        b=YU/dUoh3uwGWNPnpVHtIk/nPCs+oMZDg5nyF+d1aRralFM0M3Qs1Ezzh2sE9RdASIy
         g58Om/uvMls8bnTExeIMyTZK9D9NVUr/Yu3xy9Kz/bmQJj6LZQTg8227gLxJ35xHDGFn
         tzVpHFUc1XdwnOirUhITVlkVD3bxau61s7bvwTVhZYff+fHhjxxgB5TZuyyaZj08JaEl
         1PtTkNiYg9CkBdCWvZoE2E7vbLvFJHXGX8F+ST1seUtm3U2ZNwoQhAgmuSkM/GnU3Hxf
         ypnysAuGPUPhfuLXeqB9kWMh6jYcYm+UEYnOvB+Shd9wDkcDRAGXJpJCgZ2SUEFs7bkC
         gEcg==
X-Gm-Message-State: APjAAAVw0BiBsWbsPTAzyvzND12yVDJG14elzJxYwhb1YbGncw/QC4uP
	wJg1jcRTgO4UnZAeZWbkD4GDoq17KSiQbwYvr+mFnQ==
X-Google-Smtp-Source: APXvYqyewFJVsKxNExxZcCql97o8glZ7r/4vX0RPf+ysn1NOq4C7kUiL1FrQphHwqEdGRLDDgT9SimVN+MRJpeEBK18=
X-Received: by 2002:a9d:7847:: with SMTP id c7mr23105525otm.164.1553809135056;
 Thu, 28 Mar 2019 14:38:55 -0700 (PDT)
MIME-Version: 1.0
References: <CAK5kH3x-P+eDXtf0wsm-=sffMq6y_6QGAdavikMEOGu=R1ddeA@mail.gmail.com>
 <CAK5kH3zGox7e9o3NhQav2hutk3hZoKAeXPkH7dNK9+aSDmbemw@mail.gmail.com>
 <CAF+90c89oR5OhC6ihAiSrQZtPfCEUStevKp8jg00HVE1gcpKDg@mail.gmail.com>
 <CAF+90c_0+eDvxuNi1NyMN=K39MtaNH7qXV=WrH5D0CB943VJng@mail.gmail.com>
 <CAK5kH3xk=xNR2+5McWVaOfo9_MRS=JydTpraSB1DpQXNjkvGUQ@mail.gmail.com>
 <CAF+90c_fvgMo+Et_RDK_P-fudVQO+ZGen=F5gGxvhRsy2ntkrQ@mail.gmail.com>
 <CAK5kH3yJuh-_vkpiBNjXyr-+E_zA+bFy=cZvEVcWSb3R4qLp7g@mail.gmail.com>
 <CAF+90c_O_FLw9Ms7s34+Lqv5CvMyNi8qWW9NKn9gnh99ash+Aw@mail.gmail.com>
 <CAK5kH3w3vvqGK0H_hYfjrKa+NUFeVSUVwcN4EE=sgsUtKtCyzw@mail.gmail.com>
 <CAF+90c8bgKD6QBnfG0ROiHYhD0o+FDZHfX1MQ2oTYwB8HM3F2Q@mail.gmail.com>
 <CAK5kH3y4roW4GY0t6RVaJQ2YSZW=0SJNSPpymH9JPJJeA94rQw@mail.gmail.com> <CAK5kH3zQvzhi9QUtFWctaGHoWgN7dxpM3v0txS9yLQ30Dt430Q@mail.gmail.com>
In-Reply-To: <CAK5kH3zQvzhi9QUtFWctaGHoWgN7dxpM3v0txS9yLQ30Dt430Q@mail.gmail.com>
Date: Thu, 28 Mar 2019 17:38:43 -0400
Message-ID: <CAK5kH3zXa7zYEOzGn_EOLcSU8-gALHTF5F77SdoMkG=KczQS+A@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000008b4bbd05852e6162"
Subject: Re: [PHP-DEV] Offset-only results from preg_match
From: cananian@wikimedia.org ("C. Scott Ananian")

--0000000000008b4bbd05852e6162
Content-Type: text/plain; charset="UTF-8"

On Wed, Mar 27, 2019 at 5:41 PM C. Scott Ananian <cananian@wikimedia.org>
wrote:

> I've created https://github.com/php/php-src/pull/3994 implementing this
> fix, and confirmed that it is sufficient to get my large regexp interned
> when it is rewritten as a class constant referencing
> HTMLData::NAMED_ENTITY_REGEX.
>

After some discussion on PR #3994, it was determined that splitting the
pcre cache to allow per-request caching would be a better solution.  I'm
closing #3994 and I've created https://github.com/php/php-src/pull/4004
with an initial implementation of the split PCRE cache.
 --scott

-- 
(http://cscott.net)

--0000000000008b4bbd05852e6162--