Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:104962
MIME-Version: 1.0
References: <php.internals-104590@news.php.net> <cee93791-8516-4653-9d8e-af70bd7e1a0c@BL2NAM02FT006.eop-nam02.prod.protection.outlook.com>
 <DM5PR06MB2857BD900DFC1510DD3EA314DE5F0@DM5PR06MB2857.namprd06.prod.outlook.com>
 <CAG9XoMSktgyZ_634JyOEU_ov-kEjhhEWaxEEo31th5x+0f8M1A@mail.gmail.com> <b4752b1a-c89d-0f4b-dd20-48cfe3747677@gmail.com>
In-Reply-To: <b4752b1a-c89d-0f4b-dd20-48cfe3747677@gmail.com>
Date: Wed, 27 Mar 2019 00:09:44 +0100
Message-ID: <CAG9XoMRnK+ceLHa5kHQkZRF9w3pEhmpoVaW2dEoaHRHdOdDHCQ@mail.gmail.com>
To: Rowan Collins <rowan.collins@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000647d600585076bff"
Subject: Re: [PHP-DEV] Re: [RFC] Permit trailing whitespace in numeric strings
From: benjamin.morel@gmail.com (Benjamin Morel)

--000000000000647d600585076bff
Content-Type: text/plain; charset="UTF-8"

>
> You might want to have a stiff drink before reading through the examples
> in this RFC then: https://wiki.php.net/rfc/string_to_number_comparison


I've already browsed this RFC, I think it's a step in the right direction
and agree with it for the most part, with 2 exceptions:

- the one we're taking about here: disallow both leading AND trailing
whitespace in numeric strings
- I would also strongly suggest that 2 strings are always compared
byte-by-byte; IMO it does (*somehow*) make sense that 42 == "42.0", but it
DOES NOT make sense that "42" == "42.0". I mean, when you're comparing a
string to a number, surely you expect some kind of conversion to occur in
one way or another, but when comparing two strings, why this magic? Is that
because we want to enforce IF ($a == $b) AND ($b == $c) THEN ($a == $c) ?
If so, I would push this RFC one step further towards strictness and
suggest that:

```php
var_dump(42 == "42"); // true
var_dump(42 == "42.0"); // false
```

Which would meet this enforcement. I come across code that benefits from
automatic conversion between an integer and its string representation every
day, but have yet to encounter any code that would benefit from quirks such
as 42 == "42.0". Getting an integer as an int or as a string is no big
deal, but as soon as you start dealing with decimal strings (and floats),
you're asking for trouble if you're relying on such quirks if you ask me.

Also, may I suggest that these 2 RFCs be merged together?

https://wiki.php.net/rfc/string_to_number_comparison
https://wiki.php.net/rfc/trailing_whitespace_numerics

Ben

On Tue, 26 Mar 2019 at 23:28, Rowan Collins <rowan.collins@gmail.com> wrote:

> On 26/03/2019 21:54, Benjamin Morel wrote:
> > I almost had a heart attack after running this code. I knew that PHP had
> a
> > few quirks when comparing different types, but I had long taken for
> granted
> > that comparing 2 *strings *performed a byte-by-byte comparison.
>
>
> You might want to have a stiff drink before reading through the examples
> in this RFC then: https://wiki.php.net/rfc/string_to_number_comparison
>
> Regards,
>
> --
> Rowan Collins
> [IMSoP]
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--000000000000647d600585076bff--