Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:104895
MIME-Version: 1.0
References: <2f7acce4-69dd-d98b-6f86-1110e3589c4b@lsces.co.uk>
 <CAJW__o0NExOzXF0MCv5o3ZnKodkNydr7OTC1+te8f-pySOsw3g@mail.gmail.com>
 <14e38736-deee-1930-e4eb-21651beebb13@lsces.co.uk> <CAJW__o0Soa2SgQOb-_EeJxFTdp41cwja9pSUx4Nq87xNvY27Bg@mail.gmail.com>
 <7c0f8e83-60c0-dd7a-8f00-6d746cbb8e77@lsces.co.uk>
In-Reply-To: <7c0f8e83-60c0-dd7a-8f00-6d746cbb8e77@lsces.co.uk>
Date: Sat, 23 Mar 2019 14:32:12 +0100
Message-ID: <CAEPJdumtUXk-yj3uTbdhm+GM44q5CFdb8uevKvfs0NxA6ALEJQ@mail.gmail.com>
To: Lester Caine <lester@lsces.co.uk>
Cc: Kalle Sommer Nielsen <kalle@php.net>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000006e33d60584c300d4"
Subject: Re: [PHP-DEV] Firebird - Who are WE ...
From: kontakt@beberlei.de (Benjamin Eberlei)

--0000000000006e33d60584c300d4
Content-Type: text/plain; charset="UTF-8"

On Sat, Mar 23, 2019 at 2:22 PM Lester Caine <lester@lsces.co.uk> wrote:

> On 23/03/2019 12:46, Kalle Sommer Nielsen wrote:
> >> Now to get back to working out why Nikita's patch does not work in
> >> 7.2.16 ...
> > Obviously because the patch was made for PHP 7.3. Hint: If a
> > macro/function is not available in 7.2, then look at how it is
> > implemented in 7.3 and migrate it or see how other functions who do
> > similar functionality works and port it.
>
> When merging the patch with the older code I was fairly sure that it did
> exist already in 7.2 ... but until I can get php-src synced I'm having
> to manually scan for this stuff ... at the current rate hg-git will take
> 24 days so now I need another plan of attack :(
>

Why are you making it so complicated? php-src has a definition of the
macros, its easy to look up on github.com/php/php-src, just copy this into
the file that uses GC_ADDREF/DELREF above the usage:

#ifndef GC_ADDREF
#define GC_ADDREF(p) (GC_REFCOUNT(p)++)
#endif
#ifndef GC_DELREF
#define GC_DELREF(p) (GC_REFCOUNT(p)--)
#endif


> --
> Lester Caine - G8HFL
> -----------------------------
> Contact - https://lsces.co.uk/wiki/?page=contact
> L.S.Caine Electronic Services - https://lsces.co.uk
> EnquirySolve - https://enquirysolve.com/
> Model Engineers Digital Workshop - https://medw.co.uk
> Rainbow Digital Media - https://rainbowdigitalmedia.co.uk
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--0000000000006e33d60584c300d4--