Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:104893 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 27173 invoked from network); 23 Mar 2019 16:29:58 -0000 Received: from unknown (HELO mail4.serversure.net) (185.153.204.204) by pb1.pair.com with SMTP; 23 Mar 2019 16:29:58 -0000 Received: (qmail 22791 invoked by uid 89); 23 Mar 2019 13:22:37 -0000 Received: by simscan 1.3.1 ppid: 22782, pid: 22788, t: 0.0383s scanners: attach: 1.3.1 clamav: 0.96/m:52/d:10677 Received: from unknown (HELO ?10.0.0.7?) (lester@lsces.co.uk@81.138.11.136) by mail4.serversure.net with ESMTPA; 23 Mar 2019 13:22:37 -0000 To: Kalle Sommer Nielsen Cc: PHP internals References: <2f7acce4-69dd-d98b-6f86-1110e3589c4b@lsces.co.uk> <14e38736-deee-1930-e4eb-21651beebb13@lsces.co.uk> Message-ID: <7c0f8e83-60c0-dd7a-8f00-6d746cbb8e77@lsces.co.uk> Date: Sat, 23 Mar 2019 13:22:36 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Firebird - Who are WE ... From: lester@lsces.co.uk (Lester Caine) On 23/03/2019 12:46, Kalle Sommer Nielsen wrote: >> Now to get back to working out why Nikita's patch does not work in >> 7.2.16 ... > Obviously because the patch was made for PHP 7.3. Hint: If a > macro/function is not available in 7.2, then look at how it is > implemented in 7.3 and migrate it or see how other functions who do > similar functionality works and port it. When merging the patch with the older code I was fairly sure that it did exist already in 7.2 ... but until I can get php-src synced I'm having to manually scan for this stuff ... at the current rate hg-git will take 24 days so now I need another plan of attack :( -- Lester Caine - G8HFL ----------------------------- Contact - https://lsces.co.uk/wiki/?page=contact L.S.Caine Electronic Services - https://lsces.co.uk EnquirySolve - https://enquirysolve.com/ Model Engineers Digital Workshop - https://medw.co.uk Rainbow Digital Media - https://rainbowdigitalmedia.co.uk