Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:104688
To: PHP Internals <internals@lists.php.net>
References: <2c497732-96f8-3ef0-bc18-912220fbff4d@gmail.com>
 <bb54ff12-028c-5fb3-3ab4-05c16e39ef76@gmail.com>
Message-ID: <51049996-83bf-f59c-50bb-6b664ae4ed12@gmail.com>
Date: Tue, 12 Mar 2019 23:33:16 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.3
MIME-Version: 1.0
In-Reply-To: <bb54ff12-028c-5fb3-3ab4-05c16e39ef76@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
Subject: Re: [PHP-DEV] RFC: Locked Classes
From: rowan.collins@gmail.com (Rowan Collins)

On 12/03/2019 21:40, Stanislav Malyshev wrote:
> Isn't it just:
> trait Locked {
>    public function __set($name, $value) {
> 	throw new RuntimeException("Property $name not declared!");
>    }
>    public function __get($name) {
> 	throw new RuntimeException("Property $name not declared!");
>    }
>    public function __unset($name) {
> 	throw new RuntimeException("Property $name not declared!");
>    }
> }


Almost...

Magic methods are run both for undefined properties and out-of-scope 
ones, so at the very least this leads to unhelpful or vague error messages.

It also doesn't handle unset in the same way as the current RFC, because 
it won't affect unsetting a property that was previously defined 
(although that part of the RFC is slightly controversial, it seems).

There may be other edge cases it doesn't handle the same way an internal 
implementation would, as well, I'm not sure.

It's certainly not a major saving over hacking it together in userland, 
but nor is it a major weight to add it to the language. I think having a 
well-thought-out implementation built in (either the one in the current 
RFC, or a declare directive as has been suggested elsewhere) would 
encourage people to use it, and generally be more user-friendly.


Regards,

-- 
Rowan Collins
[IMSoP]