Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:104685
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
In-Reply-To: <bb54ff12-028c-5fb3-3ab4-05c16e39ef76@gmail.com>
Date: Tue, 12 Mar 2019 22:45:55 +0100
Cc: Rowan Collins <rowan.collins@gmail.com>,
 PHP Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <D79A526D-A8A3-404E-83CF-4B7D8200FB77@gmail.com>
References: <2c497732-96f8-3ef0-bc18-912220fbff4d@gmail.com>
 <bb54ff12-028c-5fb3-3ab4-05c16e39ef76@gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Subject: Re: [PHP-DEV] RFC: Locked Classes
From: gadelat@gmail.com (Gabriel O)

It was already addressed how using such trivial solution is =
insufficient, please read whole thread

> On 12. Mar 2019, at 22:40, Stanislav Malyshev <smalyshev@gmail.com> =
wrote:
>=20
> Hi!
>=20
>> While it can be useful, the ability to set an object property which =
is
>> not part of the class definition can also lead to subtle bugs. =
Banning
>> this for all objects would be a significant and painful breaking =
change,
>> so I propose instead the option to mark a particular class with a new
>> keyword, "locked".
>=20
> Isn't it just:
>=20
> trait Locked {
>  public function __set($name, $value) {
> 	throw new RuntimeException("Property $name not declared!");
>  }
>  public function __get($name) {
> 	throw new RuntimeException("Property $name not declared!");
>  }
>  public function __unset($name) {
> 	throw new RuntimeException("Property $name not declared!");
>  }
> }
>=20
> The RFC says:
>=20
> While this can be achieved through strategic use of the __set, __get,
> and __unset magic methods, this is long-winded, hard to optimise, and
> interferes with other uses of those methods.
>=20
> I don't see how it's "long-winded" - it's just three one-liners, I =
don't
> see how "interferes with other uses" of these methods (if you want =
other
> uses, just add code to the method), and as for optimization, I think =
we
> already have optimization for pre-declared properties, and if you =
don't
> use any others, it would work just as well.
>=20
>=20
> --=20
> Stas Malyshev
> smalyshev@gmail.com
>=20
> --=20
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>=20