Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:104647 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 90486 invoked from network); 11 Mar 2019 14:02:03 -0000 Received: from unknown (HELO mail-it1-f170.google.com) (209.85.166.170) by pb1.pair.com with SMTP; 11 Mar 2019 14:02:03 -0000 Received: by mail-it1-f170.google.com with SMTP id 188so6531738itb.0 for ; Mon, 11 Mar 2019 03:51:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VmLy8kiVL+VTdjqKUw16skavGH4rCm8v2uWcP8pLC/c=; b=I5qTSEissGgHO/sK+8yHKNQsvucX4oz7mjs1zobB+bl1Hb+5g8wdoJyBrELUVf2j/c tSZt9O3tLjoLb1t/37bq9RWJpCu3iULKkLM1Ki7sBs5EWELMqq1hweVuRYEEKVkP1aLw R0WmRWxY6v0r/JlryUn/Iej+ELoeE8J/e8PJIwVAn4hNvLe+P8Q9jYJqZfzLgr8kkGIe jVVzEsx2M0PGvr5UKZIdVXGxp0vwUiMHCzgEkx5Q5XgTxBL7StSf9yOrpD6xRJn/VtNF qN2s7CxEJdIAm9+yXa/AOxTOQGX/BDJHh7lYJSqKfCVfbRSKB/rq7Ymew231D5oqN+g1 BiAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VmLy8kiVL+VTdjqKUw16skavGH4rCm8v2uWcP8pLC/c=; b=P9UGcYm+lJmWKpMr54rWTZRlBrfHMitixU9qIUhsljZOhbGJ3OcaKn7ksYhK82evXB eGETyeEkoAf3mIEbro1b2tQqPYWIFwaHIIUyvaJlpstbf63wuvxFlBy9uJwGhdjclves 4k4O70C9k0hBwmlNqMlkuCqf03RdNlTSxScNMFpW95Bcokmt1cKmT1HbkZoPpxvlJTVD UMCMqcJ2pRusLYX0HDWZF5NC2sex0e+VjbmwuS5vMcrDe3bdyVtXuJb6FcJodHrhOIqs /bWRRzghTH9uyah0fNRl2iTSJ8VP1yTgTwXx1aDumExih3tUVMi/7IgJb3t+AOKT8jxN s6bQ== X-Gm-Message-State: APjAAAVYzu2GNe7lQLCEZe2naOHYpvGeWXy+nj3LRqjuVjY2JrbcgJ7F 4nVEDtytdT7Y0Q6+UfloHYsg4EAaI84yYF5Z6RmFsg== X-Google-Smtp-Source: APXvYqxOWj0wQZM1dCNXxkoAj2cRgtt3383iLBqAejNUMl/9WwYPfa0iQVCRdkW6tNQJXTEiblqrfgoY2ExbZcVK6zI= X-Received: by 2002:a02:168a:: with SMTP id a132mr17226604jaa.101.1552301499732; Mon, 11 Mar 2019 03:51:39 -0700 (PDT) MIME-Version: 1.0 References: <571527C8-8801-48B5-AEF7-D64CE4C83597@exussum.co.uk> In-Reply-To: <571527C8-8801-48B5-AEF7-D64CE4C83597@exussum.co.uk> Date: Mon, 11 Mar 2019 11:51:23 +0100 Message-ID: To: Scott Dutton Cc: PHP internals Content-Type: multipart/alternative; boundary="00000000000079d83f0583cf5b16" Subject: Re: [PHP-DEV] Base_convert changes From: nikita.ppv@gmail.com (Nikita Popov) --00000000000079d83f0583cf5b16 Content-Type: text/plain; charset="UTF-8" On Sun, Mar 10, 2019 at 1:29 PM Scott Dutton wrote: > Hi, > > I have just put a pull request together to make some changes to > base_convert, the changes are as follows: > > 1, Allow conversion of negative numbers (fixes > https://bugs.php.net/bug.php?id=55393) > 2, Raise a notice when passing in invalid chars as input, currently they > are just silently ignored > > Part of the negative number change causes a BC break due to needing to use > a "zend_long" instead of a "zend_ulong" this breaks a number of tests, but > allows negative numbers to be represented correctly. > > The PR is here https://github.com/php/php-src/pull/3911/files > > I look forward to hearing thoughts on this > > Thanks > > Scott Both changes sound reasonable to me. Could you show some examples where the output is going to change due to the zend_ulong->zend_long switch? Nikita --00000000000079d83f0583cf5b16--