Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:104632
MIME-Version: 1.0
References: <2c497732-96f8-3ef0-bc18-912220fbff4d@gmail.com>
In-Reply-To: <2c497732-96f8-3ef0-bc18-912220fbff4d@gmail.com>
Date: Sun, 10 Mar 2019 20:19:17 +0000
Message-ID: <CA+kxMuTA+NWgMRbG26hQWO+pXro5pANs4uVdG+aRg3yJY3ewJQ@mail.gmail.com>
To: Rowan Collins <rowan.collins@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000043f4c00583c32c3f"
Subject: Re: [PHP-DEV] RFC: Locked Classes
From: Danack@basereality.com (Dan Ackroyd)

--00000000000043f4c00583c32c3f
Content-Type: text/plain; charset="UTF-8"

On Sun, 10 Mar 2019 at 18:35, Rowan Collins <rowan.collins@gmail.com> wrote:
>
> Hi all,
>
> - Attempting to set a property on the instance which was not declared in
> the class (or inherited from one of its parent classes) will throw an
> error, and the instance will not be modified.
> - Attempting to read a property on the instance which was not declared
> (or inherited) will throw an error, rather than raising a Notice and
> evaluating to null.

I believe those two parts of the RFC are completely possible already in
user-land with a trait similar to the one below. What would be the
compelling case for making it be a keyword, rather than the user-land
implementation that is already achievable?

Also.....this seems to be a special case of an idea that has come up
repeatedly, of allowing the concept of 'packages' with rules applied to all
of the classes in a package e.g.

* class Friendship which only allows access to certain methods to other
classes in the same package.
* strict enabled by default for a classes in a package.

and now this RFC (or at least 2/3 of it) could be implemented by adding
some traits by default to all classes in a package.

Rather than adding a special case, I'd much rather we looked at providing
the general case.

cheers
Dan
Ack



trait LockedClass
{
public function __set($name, $value)
{
throw new \Exception("Property [$name] doesn't exist for class [" .
get_class($this) . "] so can't set it");
}
public function __get($name)
{
throw new \Exception("Property [$name] doesn't exist for class [" .
get_class($this) . "] so can't get it");
}
}

--00000000000043f4c00583c32c3f--