Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:104618
Return-Path: <scott@exussum.co.uk>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 73632 invoked from network); 10 Mar 2019 15:39:41 -0000
Received: from unknown (HELO thephantoms.co.uk) (176.126.243.54)
  by pb1.pair.com with SMTP; 10 Mar 2019 15:39:41 -0000
Received: (qmail 6892 invoked by uid 0); 10 Mar 2019 12:29:03 -0000
Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=private; d=exussum.co.uk;
  b=nqyzgNIlPBmWARymdlEegSkHUV8ZhOTHeIwFrEsACVqsoDOP2ps3/NwpLMAeQA25;
Received: from 05403454.skybroadband.com (HELO android-169b3ce0b562060) (scott@exussum.co.uk@5.64.52.84)
  by exussum.co.uk with ESMTPA; 10 Mar 2019 12:29:03 -0000
Date: Sun, 10 Mar 2019 12:29:00 +0000
User-Agent: K-9 Mail for Android
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="----CFSKIWQEPG338BOAOB0HD7JK0H6YI8"
Content-Transfer-Encoding: 7bit
To: internals@lists.php.net
Message-ID: <571527C8-8801-48B5-AEF7-D64CE4C83597@exussum.co.uk>
Subject: Base_convert changes
From: scott@exussum.co.uk (Scott Dutton)


------CFSKIWQEPG338BOAOB0HD7JK0H6YI8
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi,

I have just put a pull request together to make some changes to base_conve=
rt, the changes are as follows:

1, Allow conversion of negative numbers (fixes https://bugs=2Ephp=2Enet/bu=
g=2Ephp?id=3D55393)
2, Raise a notice when passing in invalid chars as input, currently they a=
re just silently ignored

Part of the negative number change causes a BC break due to needing to use=
 a "zend_long" instead of a "zend_ulong" this breaks a number of tests, but=
 allows negative numbers to be represented correctly=2E

The PR is here https://github=2Ecom/php/php-src/pull/3911/files

I look forward to hearing thoughts on this

Thanks

Scott
------CFSKIWQEPG338BOAOB0HD7JK0H6YI8--