Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:104527
To: Nikita Popov <nikita.ppv@gmail.com>, PHP internals
	<internals@lists.php.net>
Thread-Topic: [PHP-DEV] [RFC] Saner string to number comparisons
Thread-Index: AQHUzc6wG2Qe9FJuvku5V6pZbs9F4aXzRmiE
Date: Wed, 27 Feb 2019 07:53:25 +0000
Message-ID:
 <MN2PR02MB57755C29630116FE3981C277BF740@MN2PR02MB5775.namprd02.prod.outlook.com>
References:
 <CAF+90c821boRO6YsO0SH0JbDb8E8eTHfEK=e4Y5_z9P7+OOnUg@mail.gmail.com>
In-Reply-To:
 <CAF+90c821boRO6YsO0SH0JbDb8E8eTHfEK=e4Y5_z9P7+OOnUg@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: zend.com does not designate
 permitted sender hosts)
Content-Type: multipart/alternative;
	boundary="_000_MN2PR02MB57755C29630116FE3981C277BF740MN2PR02MB5775namp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4677102d-5f7f-4f6b-eb70-08d69c88a783
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2019 07:53:25.7648
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR02MB5856
Subject: Re: [PHP-DEV] [RFC] Saner string to number comparisons
From: dmitry@zend.com (Dmitry Stogov)

--_000_MN2PR02MB57755C29630116FE3981C277BF740MN2PR02MB5775namp_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Hi Nikita,


Yeah, this is a big BC break, but I think, it's a good time to make some "c=
leanup" in PHP-8.

The only thing, I don't like is a difference between leading and trailing s=
paces.

They should behave in the same way.


Thanks. Dmitry.

________________________________
From: Nikita Popov <nikita.ppv@gmail.com>
Sent: Tuesday, February 26, 2019 3:27:23 PM
To: PHP internals
Subject: [PHP-DEV] [RFC] Saner string to number comparisons

Hi internals,

I think it is well known that =3D=3D in PHP is a pretty big footgun. It doe=
sn't
have to be. I think that type juggling comparisons in a language like PHP
have some merit, it's just that the particular semantics of =3D=3D in PHP m=
ake
it so dangerous. The biggest WTF factor is probably that 0 =3D=3D "foobar"
returns true.

I'd like to bring forward an RFC for PHP 8 to change the semantics of =3D=
=3D
and other non-strict comparisons, when used between a number and a string:

https://wiki.php.net/rfc/string_to_number_comparison

The tl;dr is that if you compare a number and a numeric string, they'll be
compared as numbers. Otherwise, the number is converted into a string and
they'll be compared as strings.

This is a very significant change -- not so much because the actual BC
breakage is expected to be particularly large, but because it is a silent
change in core language semantics, which makes it hard to determine whether
or not code is affected by the change. There are things we can do about
this, for example the RFC suggests that we might want to have a transition
mode where we perform the comparison using both the old and the new
semantics and warn if the result differs.

I think we should give serious consideration to making such a change. I'd
be interested to hear whether other people think this is worthwhile, and
how we could go about doing it, while minimizing breakage.

Regards,
Nikita

--_000_MN2PR02MB57755C29630116FE3981C277BF740MN2PR02MB5775namp_--