Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:104388
Return-Path: <johannes@schlueters.de>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 41267 invoked from network); 13 Feb 2019 18:08:29 -0000
Received: from unknown (HELO mail.experimentalworks.net) (84.19.169.162)
  by pb1.pair.com with SMTP; 13 Feb 2019 18:08:29 -0000
Received: from kuechenschabe.fritz.box (ppp-188-174-116-193.dynamic.mnet-online.de [188.174.116.193])
	by mail.experimentalworks.net (Postfix) with ESMTPSA id 394BC5332D;
	Wed, 13 Feb 2019 15:51:38 +0100 (CET)
Message-ID: <1550069493.3132.5.camel@schlueters.de>
To: Remi Collet <remi@php.net>, PHP internals <internals@lists.php.net>
Date: Wed, 13 Feb 2019 15:51:33 +0100
In-Reply-To: <761dc9c9-bd4a-4538-d99e-f10ac2775903@php.net>
References: <761dc9c9-bd4a-4538-d99e-f10ac2775903@php.net>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Drop support for libreadline
From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

Hi,

On Mi, 2019-02-13 at 11:56 +0100, Remi Collet wrote:
> Hi,
> 
> 
> Terribly old and known issue.
> 
> libreadline license (GPL) is incompatible with PHP
> 
> We support build with libedit (BSD) for years
> 
> Most Linux distribution use libedit
> Windows also use libedit
> 
> 
> So, this PR is mostly a cleanup of what should have been removed for
> years.
> 


I don't know the size of the patch for this, but as long as we are not
using readline-specific APIs isn't it the user's choice/responsibility
if they happen to link to readline? - As long as that isn't
distributed, but only for their own use it's fine. GPL limits
"redistribution" not "usage"

It is a while since I used libedit last, but in behavior it had notable
differences.

johannes