Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:104385
To: Remi Collet <remi@php.net>, PHP internals <internals@lists.php.net>
References: <761dc9c9-bd4a-4538-d99e-f10ac2775903@php.net>
Message-ID: <382517f9-cc05-f4f7-fc6a-a65cffe826bc@gmx.de>
Date: Wed, 13 Feb 2019 12:51:01 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.0
MIME-Version: 1.0
In-Reply-To: <761dc9c9-bd4a-4538-d99e-f10ac2775903@php.net>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Subject: Re: Drop support for libreadline
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 13.02.2019 at 11:56, Remi Collet wrote:

> Terribly old and known issue.
> 
> libreadline license (GPL) is incompatible with PHP
> 
> We support build with libedit (BSD) for years
> 
> Most Linux distribution use libedit
> Windows also use libedit
> 
> 
> So, this PR is mostly a cleanup of what should have been removed for years.
> 
> 
> Feedback before merge ?

I'm fine with dropping libreadline support, but it should be pointed out
that readline_list_history() doesn't work with libedit, and would be
completely removed.

-- 
Christoph M. Becker