Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:104372
MIME-Version: 1.0
References: <CAEQoxLLH0DgFLETMHiwUbjFsk0D=MNSachFZ=JN-ucY8KV5sZw@mail.gmail.com>
 <55E49E9F-9E09-4AA2-ACC3-C0FF3FE7EF09@benramsey.com>
In-Reply-To: <55E49E9F-9E09-4AA2-ACC3-C0FF3FE7EF09@benramsey.com>
Date: Tue, 12 Feb 2019 21:21:14 +0200
Message-ID: <CAEQoxLJ+A8OagYHtCH4va5VBt38m+YLhhZ_j-71wnnzwoYfVFg@mail.gmail.com>
To: Ben Ramsey <ben@benramsey.com>
Cc: internals@lists.php.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Make bcmath functions more strict
From: vladyslavstartsev@gmail.com (Vladyslav Startsev)

On Fri, Feb 8, 2019 at 1:07 AM Ben Ramsey <ben@benramsey.com> wrote:
>
> > On Feb 7, 2019, at 11:47, Vladyslav Startsev <vladyslavstartsev@gmail.c=
om> wrote:
> >
> > Hello everyone!
> >
> > Recently I noticed that there are strange behavior going on if I use
> > bcmath functions (some examples you can see here
> > https://3v4l.org/D3s7J). I also previously had little discussion with
> > Sara Golemon on twitter about this
> > (https://twitter.com/SaraMG/status/1087902930110480384). So to
> > conclude things that I want, is drop behavior (they should throw
> > invalid argument exception) that I've showed in the first link and as
> > Sara suggested add deprecation warning (but I think it should be
> > E_NOTICE level errors) in 7.4.
>
>
> Another option to consider is to adopt the same approach as standard
> math in PHP. Here=E2=80=99s an example using standard addition for the sa=
me
> values: https://3v4l.org/iMGg8
>
> So, maybe it should emit notices and warnings instead?
>
>     Notice: A non well formed numeric value encountered in=E2=80=A6
>     Warning: A non-numeric value encountered in=E2=80=A6
>
> Cheers,
> Ben

Ha! I like your idea Ben. Should I make RFC? Since no one else responded