Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:104370
MIME-Version: 1.0
References: <CAF+90c-q631w16DahA9bZPWyZPtYMaA0yB+vvKLxKi3AApUQDg@mail.gmail.com>
 <CAEYWF=75d2wik1r1_p7VxMPSgncBRhp9od=dVuzMGYebOT0+-Q@mail.gmail.com> <CAF+90c-8ZHja9y=1jqRkGO=1+g4PhJ2132J6ObQU6KtkN709GQ@mail.gmail.com>
In-Reply-To: <CAF+90c-8ZHja9y=1jqRkGO=1+g4PhJ2132J6ObQU6KtkN709GQ@mail.gmail.com>
Date: Tue, 12 Feb 2019 10:21:09 -0600
Message-ID: <CAESVnVp6uKDdJCXfSuCs+rSC1fJbDHAGXSKN0cE=5=Yyv0Pr5A@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Bishop Bettini <bishop@php.net>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000c7b2ab0581b4d010"
Subject: Re: [PHP-DEV] Convert ext/xml to use an object instead of resource
From: pollita@php.net (Sara Golemon)

--000000000000c7b2ab0581b4d010
Content-Type: text/plain; charset="UTF-8"

On Tue, Feb 12, 2019 at 10:18 AM Nikita Popov <nikita.ppv@gmail.com> wrote:
> Very much opposed to any kind of special handling for is_resource(). We
> used to do this for is_object() and __PHP_Incomplete_Class and I'm very
> happy to be rid of this special behavior. Let's not add is back in a new
> place.
>
Agreed. This is something that we discuss every time a resource->object
conversion comes up and we always agree that special-casing lies the way of
madness and the tiny fraction of user code that actually checks this can
adapt   `if (is_resource($x) || $x instanceof NewClassName)`  Done and
sorted. Let's skip this repeat of the past and move forward with the
killing all resources with fire.

-Sara

--000000000000c7b2ab0581b4d010--