Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:104368
MIME-Version: 1.0
References: <CAF+90c-q631w16DahA9bZPWyZPtYMaA0yB+vvKLxKi3AApUQDg@mail.gmail.com>
 <CAEYWF=75d2wik1r1_p7VxMPSgncBRhp9od=dVuzMGYebOT0+-Q@mail.gmail.com> <CALKiJKqrfyESNZXXGpiO0xp-OQkqDeL6gThO9kxf24AL9pnJhw@mail.gmail.com>
In-Reply-To: <CALKiJKqrfyESNZXXGpiO0xp-OQkqDeL6gThO9kxf24AL9pnJhw@mail.gmail.com>
Reply-To: bishop@php.net
Date: Tue, 12 Feb 2019 11:12:31 -0500
Message-ID: <CAEYWF=7D3xFmDbk_0Wm8oou3UUgjgEOJcaAgdR5ApoM5rSZ7Vw@mail.gmail.com>
To: Rowan Collins <rowan.collins@gmail.com>
Cc: Nikita Popov <nikita.ppv@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000da58020581b4b28b"
Subject: Re: [PHP-DEV] Convert ext/xml to use an object instead of resource
From: bishop@php.net (Bishop Bettini)

--000000000000da58020581b4b28b
Content-Type: text/plain; charset="UTF-8"

On Tue, Feb 12, 2019 at 11:04 AM Rowan Collins <rowan.collins@gmail.com>
wrote:

> On Tue, 12 Feb 2019 at 15:30, Bishop Bettini <bishop@php.net> wrote:
>
> > +1 for movement away from resources, generally.
> >
> > Resources represent connections to external resources, in a manner that's
> > opaque to userland [1]. Would it make sense to update is_resource (and
> > friends) to be aware that "resources" returned from xml_parser_* are not
> > resources proper, but rather resources nominal?
> >
>
>
> While such a feature would have limited use in this case, as Johannes
> points out, it might be a nice general pattern to establish for migrating
> other resources in future. All such objects could implement an empty
> "Resource" interface, which couldn't be implemented directly from userland,
> and just triggered this magic behaviour.
>

Exactly. I hope we would adopt a long-vision, since migrating from
resources to objects has been discussed as the desired future state of
things.


> There would still be other BC impacts, though; for instance, gettype()
> would return "object" instead of "resource", unless we overloaded that
> based on the interface as well, which might be a bit confusing.
>

I think gettype should return "resource" for BC, but get_resource_type
would be free to add more context about the now-object nature.

--000000000000da58020581b4b28b--