Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:104352
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
References: <CAF+90c-WhpsCJQ9rB7vdqLv_10fjz-Eng=CHY2fk6W+eWGnVjA@mail.gmail.com>
 <CAF+90c98pYOgPcJUfEri7D9+TMAge4HyLJx9xULfGLd5ruekbA@mail.gmail.com>
 <aef6e8e0-de8b-4bc2-d642-3df632d9e18b@gmx.de>
 <CAF+90c8RHACAZ3nAp8fH4dJ3mXERexS7bsWnR8jQQUhWangh9A@mail.gmail.com>
Message-ID: <d636eaab-d1e2-3d2c-afed-649b41325a7b@gmx.de>
Date: Mon, 11 Feb 2019 20:00:34 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.0
MIME-Version: 1.0
In-Reply-To: <CAF+90c8RHACAZ3nAp8fH4dJ3mXERexS7bsWnR8jQQUhWangh9A@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Subject: Re: [VOTE] Deprecate and remove case-insensitive constants
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 08.02.2019 at 09:59, Nikita Popov wrote:

> On Thu, Feb 7, 2019 at 11:31 PM Christoph M. Becker <cmbecker69@gmx.de>
> wrote:
> 
>> I just learned that com_load_typelib()[1] automatically registers enum
>> members as constants, and allows to register them as case-insensitive
>> (the default is case-sensitive, despite the documentation, which I'm
>> going to fix right away).  If a typelib is implicitly loaded,
>> com.autoregister_casesensitive[2] controls whether constants are
>> registered case-sensitively or not.  It seems to me com_load_typelib()
>> should trigger a deprecation warning, if FALSE is passed as second
>> argument, and also disabling com.autoregister_casesensitive should.
>>
>> Can this be amemded for PHP 7.3.3, or are there any objections?
>>
>> [1] <http://php.net/manual/en/function.com-load-typelib.php>
>> [2]
>> <
>> http://php.net/manual/en/com.configuration.php#ini.com.autoregister-casesensitive
> 
> Thanks for pointing this out! Agree that both of those should be deprecated
> .... in fact the necessary for code handling case-insensitive constants is
> already gone in master, so they'll definitely have to go as well.
> 
> Personally I think it would be best to add the deprecations in 7.4, as
> there's no particular rush and we usually don't add deprecations in patch
> releases. I don't have a problem with them being added in 7.3.3 either
> though, this is not exactly prime functionality and we're early in the
> release cycle...

Postponing this to 7.4 is fine for me.  I'll provide a respective PR
within the next days.

-- 
Christoph M. Becker