Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:104349 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 7904 invoked from network); 11 Feb 2019 20:45:06 -0000 Received: from unknown (HELO mail-qt1-f177.google.com) (209.85.160.177) by pb1.pair.com with SMTP; 11 Feb 2019 20:45:06 -0000 Received: by mail-qt1-f177.google.com with SMTP id b8so13057713qtr.9 for ; Mon, 11 Feb 2019 09:27:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hTqpVMZM/e0ZZ/q+c5Vse4kQjATHShuApbTp5LQc3yQ=; b=nt5YpLgkWMN/5o5kZPs80VD2UcoPDn7Jv1CKG6LPnG2t5Nnq4cFjf8YiP2yUulT7gE ifuDNQ+UikAXvsJyq8EA350vMDU7VmG1e4iLspkYHHnCX1sB83WM+KF/Zvtl7wtw+6Lc HEqb4q6fjtIunafK0BLDdqsrHN2qe7OOGcQn1+xEKnB2ol2JGVyNRAnXEEGYijhiCLoi 06cTUv4So2elDcsneiBgVDcqym0B8i/uQbGtD525srL5z42VTE6enkK4RPmxj46muEFK xslTzVKgfIE4LiYtnFuZp37MF53RvCcUjta/EWGrM0/dJHq8F/cczkwkv7VFPEjeL9zv nVeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hTqpVMZM/e0ZZ/q+c5Vse4kQjATHShuApbTp5LQc3yQ=; b=fC9YFxdxJ99M6Xt8ahLVkIfK8/mPjgpNRabKijSwcoqWSz2mmEOTgNnaH8nrStLHsU 7t0+DVKX29YZ/+XE6XWZ2HPa5+8jJ51XYlY5iDou1Bd4zk35J5b9W0HU1Rzpg8t0XstP QU3IrJyyo/xdeVk187r+drRnYCtdp2AJvu5L8JfuLW1P3CK3y7do48EATBS20jvl9aAh jp9Ltt7h2ZH2wrbw3x7yjHIl+XlyfZrGH+H9kgPojxp6cNXFouo0bsMYQ/oSxOSxwzu9 gVEzDSoVeM3+PMAoyW69a/1f08FsrM3CVdXeCq5xROHMoxjFSpB+P2P5xOulBtFQFW4M rl3w== X-Gm-Message-State: AHQUAuYPpPAiyR/8YLq9J/XMq3KB+nkM1qzhE1LvYP4RMEP1bZbF7GXC BWwlQMVgmdIc5RA1aswcXQ4JdBWX7ZerSKBJ0ZFgMXTX X-Google-Smtp-Source: AHgI3IZ6dFEBBaDicVX5JY7QEiI/YFUtCnlOf85uJzH5VTkshmamAjPTIcXd5nt9El/fbQH1PWn1HTkpF8vKZQqVxWI= X-Received: by 2002:a0c:9e05:: with SMTP id p5mr27180558qve.246.1549906066636; Mon, 11 Feb 2019 09:27:46 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: Date: Mon, 11 Feb 2019 18:27:33 +0100 Message-ID: To: Dan Ackroyd Cc: PHP internals Content-Type: multipart/alternative; boundary="0000000000008986520581a1a0a9" Subject: Re: [PHP-DEV] reasonability of change the mbfl library From: legale.legale@gmail.com (Legale Legage) --0000000000008986520581a1a0a9 Content-Type: text/plain; charset="UTF-8" Got it. Thanks. On Mon, Feb 11, 2019, 18:00 Dan Ackroyd On Sun, 10 Feb 2019 at 12:29, Legale Legage > wrote: > > > > > > > https://github.com/php/php-src/pull/3715/commits/d868059626290b7ba773b957045e08c3efb1d603#diff-22d593ced03b2cb94450d9f9990865c8R38 > > > > To do, or not to do: that is the question. > > What do you think? > > Opening separate pull requests for separate changes is good as it > allows them to be discussed separately. That change is bundled with > the mb_str_split() changes, so it's quite hard to see what is > optimisation and what is part of the approved RFC. > > Although memory is cheap, the change appears to increase the static > allocation of memory by 128KB for something that >95% of PHP > programmers will never use, which is not a good idea. > > > show a more than 2 times speed increase. > > Lies, damn lies and statistics. > > If it takes the time to parse a megabyte string from 0.000002 to > 0.000001, no one cares. > If it takes the time to parse a megabyte string from 2 seconds to 1 > second, wow that's great! > > i.e. Saying a two times speed increase without context doesn't give > people enough information to evaluate it. > > But this would be easier to discuss as a separate PR. > > cheers > Dan > --0000000000008986520581a1a0a9--