Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:104341
MIME-Version: 1.0
References: <CAF+90c_wZvdgVbmdHH+7J=CLx-rivDRr4vB3=HXK3K2HSNAqMg@mail.gmail.com>
 <CAF+90c_HaeydyEk2qyM=vxQC-_N6KKwCw_WPo1osP1Nkv99cfw@mail.gmail.com>
 <CAJHtznyX9P565B9S+3PHmX1m_SY32e_2eb3fjjYmsMRWue3LEA@mail.gmail.com>
 <CAF+90c9m-ghnr7ZNpYmJ1b14Ah8P==jHc40ZGVHLS4dgx5Q05w@mail.gmail.com>
 <CAJHtznxB4MiV825pQa39X238_u_USX88vTCS8fvLZd=gjnoETw@mail.gmail.com> <27c296a0-c355-e4b4-88ec-c0e30c117226@gmx.de>
In-Reply-To: <27c296a0-c355-e4b4-88ec-c0e30c117226@gmx.de>
Date: Mon, 11 Feb 2019 16:23:35 +0100
Message-ID: <CAF+90c_dJGruV-sarCMHfxw3WuCmMafj7MGozi-G8k6Hw7UnBA@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: Zeev Suraski <zeev@php.net>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000086ed8505819fe503"
Subject: Re: [PHP-DEV] Re: Don't silence fatal errors
From: nikita.ppv@gmail.com (Nikita Popov)

--00000000000086ed8505819fe503
Content-Type: text/plain; charset="UTF-8"

On Wed, Feb 6, 2019 at 10:45 PM Christoph M. Becker <cmbecker69@gmx.de>
wrote:

> On 06.02.2019 at 05:42, Zeev Suraski wrote:
>
> > As long as we have a prominent warning about this in our migration guide
> > alerting people to the associated risk in setups where display errors is
> on
> > - I can live with the change as-is.  How do we ensure that it doesn't get
> > lost in the clutter given that it has no RFC?
>
> Generally, *everything* that needs to be mentionend in the migration
> guide, should have a respective entry in UPGRADING.  That makes creating
> the migration guide straight forward for the doc team, and worked quite
> well for PHP 7.3 at least.
>

As the discussion here has drifted off towards error handling in general
and there hasn't been any further input on the change itself, I've gone
ahead and committed this:
https://github.com/php/php-src/commit/a302d1161036988fe220ecd8ecd73e6af1a116fc
I've also included a few UPGRADING notes.

Nikita

--00000000000086ed8505819fe503--