Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:104297
Message-ID: <55E49E9F-9E09-4AA2-ACC3-C0FF3FE7EF09@benramsey.com>
Content-Type: multipart/signed;
	boundary="Apple-Mail=_2B8AB3CF-1F13-46FA-A03D-55DB80BF536D";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Date: Thu, 7 Feb 2019 17:07:41 -0600
In-Reply-To: <CAEQoxLLH0DgFLETMHiwUbjFsk0D=MNSachFZ=JN-ucY8KV5sZw@mail.gmail.com>
Cc: internals@lists.php.net
To: Vladyslav Startsev <vladyslavstartsev@gmail.com>
References: <CAEQoxLLH0DgFLETMHiwUbjFsk0D=MNSachFZ=JN-ucY8KV5sZw@mail.gmail.com>
Subject: Re: [PHP-DEV] Make bcmath functions more strict
From: ben@benramsey.com (Ben Ramsey)

--Apple-Mail=_2B8AB3CF-1F13-46FA-A03D-55DB80BF536D
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

> On Feb 7, 2019, at 11:47, Vladyslav Startsev =
<vladyslavstartsev@gmail.com> wrote:
>=20
> Hello everyone!
>=20
> Recently I noticed that there are strange behavior going on if I use
> bcmath functions (some examples you can see here
> https://3v4l.org/D3s7J). I also previously had little discussion with
> Sara Golemon on twitter about this
> (https://twitter.com/SaraMG/status/1087902930110480384). So to
> conclude things that I want, is drop behavior (they should throw
> invalid argument exception) that I've showed in the first link and as
> Sara suggested add deprecation warning (but I think it should be
> E_NOTICE level errors) in 7.4.


Another option to consider is to adopt the same approach as standard
math in PHP. Here=E2=80=99s an example using standard addition for the =
same
values: https://3v4l.org/iMGg8

So, maybe it should emit notices and warnings instead?

    Notice: A non well formed numeric value encountered in=E2=80=A6
    Warning: A non-numeric value encountered in=E2=80=A6

Cheers,
Ben

--Apple-Mail=_2B8AB3CF-1F13-46FA-A03D-55DB80BF536D
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iHUEAREIAB0WIQToXQMR3fpbrPOmEOewLZeYnIwHGwUCXFy6PQAKCRCwLZeYnIwH
G7bWAQCWc5QZ501Bxa6hiYVlnncErEWQP2kM3qw+LQ4Yz6ULCwD/QYug8NuEvUyJ
Ai4r6G3IRh9deXkwByR7rMDgLPJa6SY=
=4BvQ
-----END PGP SIGNATURE-----

--Apple-Mail=_2B8AB3CF-1F13-46FA-A03D-55DB80BF536D--