Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:104294 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 487 invoked from network); 7 Feb 2019 20:19:50 -0000 Received: from unknown (HELO mail-ot1-f45.google.com) (209.85.210.45) by pb1.pair.com with SMTP; 7 Feb 2019 20:19:50 -0000 Received: by mail-ot1-f45.google.com with SMTP id s5so954112oth.7 for ; Thu, 07 Feb 2019 09:01:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UGWjmOFrSgbO4E5zk7CNbS6RA8cbDwe4iFT/WBI6C00=; b=NzpDCA7EMvcq+JljuwRgGM36W2vX2vkq037mM0BbLECDSuvPu1p+aYR8hYS8pOKpbH LMCpDCuiVt8e2l0WmNSLT60VUmwUT8Q3a2pJDLKjoCBkGAQaacA7H2skGQEpJnY5qgTI i71FCb3UT+f9X7l0w250w9ydcX66GMvwmUi1Vv6eGvfqd+yiL8WScueyY+U6tjuvzs3y Y0E/yHILeUdL9C8iBNrJmGgJj/As5bPiGP7G5hoVpNUUK9kg0Nh+n0cNXA7T4hoSsbU9 rbupxtEbxfVcDsM0QRCLFC5J1SqCuFuAug476uIb7pWxzOLYIwJCWGhQsyoJpZhALJRD a9VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UGWjmOFrSgbO4E5zk7CNbS6RA8cbDwe4iFT/WBI6C00=; b=exzRPQ8nXkd99+dMbmBSBMX2pyCo9KsuI2zJvDo+GuQlYVMPvdIV4dJD4dVt+vCbmN 5++Yvw7wOwoYZNuTv3BVxNPNxskkIL3QaOvPiY1IksEhQ2DqfO6J4Cqqe8fP/axippSz wqE1EmhsO/umkamKFmw6ie5G76yo6M9hxSfX2xIT7iyUNtMiygo2Yze7jdTXtY8SBgvN XQsoxpenwBD5Vc4xKCPy24oKeMs15IzDw6gw5Yi/HCiS5bLMI45nVp+hX3F0/K7vTARh MrtKnAqha6dKBv9TmGk8OBBrpu12+mkZNih4Y7+FK2DF1VNwnmd5t1l8o3u8e7Os5kj1 RsCQ== X-Gm-Message-State: AHQUAuaS2ecSWRJOT5nhk1eCQjxCgXgPbAxpKtoh414w9v8ybqOGso66 L9ExLIq3d1XIyM4xSaliamo5IOUDfaDfSRnBFOA= X-Google-Smtp-Source: AHgI3IbOWlbM31ulM62dn0BvHDcLOCh/wAUjjQgw8GDQhFqEg9ZFNeNbFRNdNRRxXEehhgo0WsHK5wrrcBLn1ycDzbY= X-Received: by 2002:aca:7581:: with SMTP id q123mr855516oic.176.1549558890262; Thu, 07 Feb 2019 09:01:30 -0800 (PST) MIME-Version: 1.0 References: <3f5873fe-3fe9-d230-28eb-a20d67550b45@lange.demon.co.uk> <25859B0A-1633-4FB7-8192-EADBA99A0013@benramsey.com> In-Reply-To: Date: Thu, 7 Feb 2019 18:01:19 +0100 Message-ID: To: "Christoph M. Becker" Cc: Sjon Hortensius , Internals , Ben Ramsey , Mark Baker Content-Type: multipart/alternative; boundary="0000000000003673e0058150cb9c" Subject: Re: [PHP-DEV] 2016 TestFest, did the tests written then ever get merged? From: peterkokot@gmail.com (Peter Kokot) --0000000000003673e0058150cb9c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, On Thu, 7 Feb 2019, 16:52 Christoph M. Becker On 07.02.2019 at 16:14, Sjon Hortensius wrote: > > > On Wed, Feb 6, 2019 at 4:14 PM Ben Ramsey wrote: > > > >>> On Feb 6, 2019, at 01:22, Peter Kokot wrote: > >>> I can help sort this mess. A separate fork out of the php/php-src was > >>> not such a good idea. > >> > >> Sorry. I made many poor decisions around how I managed that entire > event. > >> It=E2=80=99s my own personal Fyre Festival. :-( > >> > >> I=E2=80=99m happy to help in any way I can to get these ready to merge= into > >> php-src. Let me know how I can help. > > > > anyone with access to the php-src git repo should be able to merge them > > pretty easily; it's a matter of running: > > > > curl -s ' > > > https://github.com/phpcommunity/phptestfest-php-src/pulls?page=3D1&q=3Dis= %3Apr+is%3Aopen+review%3Aapproved'|grep > > > -Po '(?<=3D
> do > > curl > > > https://patch-diff.githubusercontent.com/raw/phpcommunity/phptestfest-php= -src/pull/$id.patch|git > > am > > done > > > > and increase the page-number in the first URL to includes pages 2 & 3 a= s > > well. Run this in your checkout (possibly on a branch) and push that to > > github > > It seems to me that the tests should be reviewed (again). The first one > I've seen[1], should be removed, since it tests general ZPP behavior, > and we're in the process to remove such tests generally[2]. > > [1] > < > https://github.com/phpcommunity/phptestfest-php-src/pull/155/files#diff-3= 3e85609b0c12ee2d4b1c5f6190fdfa4 > > > [2] > > -- > Christoph M. Becker > Hello, thanks for the info. Yes, the suggested script might seem like this can be done in a simple way. However, I have no idea in what state the pull requests at the forked repository are so I suggest we start opening separate pull requests one by one to target PHP 7.4 branch. So overall, ~139 pull requests. With 1-5 per day, we can have this fixed in a month to several months or so. If more people can help opening pull requests, so much faster this can be done. Fetching remote branch from another fork is quite easy: git checkout -b patch-1 upstream/PHP-7.4 wget https://github.com/phpcommunity/phptestfest-php-src/pull/1.patch git am -3 1.patch # recheck commits, rebase, fix conflicts etc git push origin patch-1 # Open pull request to recheck and merge into PHP-7.4 and master. Example: https://github.com/php/php-src/pull/3802 -- Peter Kokot > --0000000000003673e0058150cb9c--