Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:104292
Return-Path: <cmbecker69@gmx.de>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 83829 invoked from network); 7 Feb 2019 19:10:49 -0000
Received: from unknown (HELO mout.gmx.net) (212.227.15.15)
  by pb1.pair.com with SMTP; 7 Feb 2019 19:10:49 -0000
Received: from [192.168.2.138] ([91.8.167.74]) by mail.gmx.com (mrgmx001
 [212.227.17.190]) with ESMTPSA (Nemesis) id 0M6BKc-1h3NwD0YLy-00y62x; Thu, 07
 Feb 2019 16:52:23 +0100
To: Sjon Hortensius <sjon@hortensius.net>,
 "internals@lists.php.net" <internals@lists.php.net>
Cc: Peter Kokot <peterkokot@gmail.com>, Ben Ramsey <ben@benramsey.com>,
 Mark Baker <mark@lange.demon.co.uk>
References: <3f5873fe-3fe9-d230-28eb-a20d67550b45@lange.demon.co.uk>
 <CAAfnsFXubTRoyof0E+x+6Q2bBtdpyX6fweAMU6eNfkHS20acdQ@mail.gmail.com>
 <25859B0A-1633-4FB7-8192-EADBA99A0013@benramsey.com>
 <CAK_tfub70_BuEXETRo=8ZgW+uReHwhKwWwvPuQYAFoSaamaMsA@mail.gmail.com>
Message-ID: <ceaad5e9-be7c-8b4e-47a3-ce942192f38b@gmx.de>
Date: Thu, 7 Feb 2019 16:52:23 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.0
MIME-Version: 1.0
In-Reply-To: <CAK_tfub70_BuEXETRo=8ZgW+uReHwhKwWwvPuQYAFoSaamaMsA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K1:oV+7ls/I4BuEjYOnF7Hwn72pVxzewlHfXmsbGr/kJ3aH1SkC8l4
 7b3Z1n7DQAe6UNcgZkz9rsglRDsJGfct7cfJTKfqqsMhoqYY6Tvheyv2TrZyYQtbl7E3oUD
 CKgKX7n6afft7wYjTpsD4Yvn3YB8eRs8iJde6gzxRqtpApKKCgu1AAsPFhAALQw+ptx0n5+
 C7CjIhzzkiEUwcAQ0F9dg==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:87cBmGRkUCA=:rzTb0VhpqtQoqObh4JpxKa
 U4a5tjALvRqk6njJIawoXhc9C77TftOalF9wBsMKm7jSKdjDURVnyGcPzmk9i5ZgfFi6k5AJ3
 Q/S9L1cfdvha+k0j9+dF1AfXDudCx5GXZHzDyyDZRMif5qnC20ak16yoB/buDEbaKdKxMTZbu
 5K5a0DTtQxbdDFHbWhKHWyyUeh6p8CbfvXCWz15whik7q+QXx74lIYTI3wpEvodt69cVlYi+3
 LbxFszHItqJqthbdnpmAT5zrRa6Uz8z76lnVXRVYSnfMXuFljGm1/Ux9UmNCuq7hN4TpqPHbK
 XWp3cQvPeg6Z1X02VrcQbvDBgIc6285sfzUddgT0QUl68wha0RASaM5voatFrm3mMyv1aJc5U
 q2P8jnjfM408X+kyfvX+Nky3zGBoC8jSoMgtL/IbYDoj0uN3V4sT2Ugv7DXMQqif7EY0H62El
 7YdqFVFyT8YDRjmebwsnyOJLaeGN+reeHj1RuzESf5/x1ky0rpwEUlcC1zL18X9bsyvtgx/nS
 xEksgHXcWTajtL8W0ZRK9Rrt3GDcgUuQqGhudZaI4UC9QyuN+e/d07HiMcxsINjzqWtC4bvwo
 dgt5/9JGdwDvd/NFJ6asMcXYGHabi5Xp0tGd7YL4DwylxddUYPShkuLhQfv3HV6fvW04eGLiG
 WPqwJQnvyJI23IoFEdUov64n+76r7HiBEa0ocH9idb1G8/zG5z0ifzHlCAS+gun1FnFY0H+Pg
 WPxJucVL/VlknKK5pK+qpT7Yp2afpMk1wy34LFK/5VXSU+0Y3YFC6KjxXdRKiFaO2AfoPzst+
 em3K0LnE//DCoaSZfmDHu3X89SOJRLZp86+yCdpbKvpLFOXcFqavI8/8oa+wBlfnAu/gvfoH+
 XLu5cZ4YQKDuvXbsfJ3FE678LOVRJGmd7tF2apphLMtDrM/S3P2Eq8KwtCX1XhMRNs4WRnJrm
 c1QGjlhWNTg==
Subject: Re: [PHP-DEV] 2016 TestFest, did the tests written then ever get
 merged?
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 07.02.2019 at 16:14, Sjon Hortensius wrote:

> On Wed, Feb 6, 2019 at 4:14 PM Ben Ramsey <ben@benramsey.com> wrote:
> 
>>> On Feb 6, 2019, at 01:22, Peter Kokot <peterkokot@gmail.com> wrote:
>>> I can help sort this mess. A separate fork out of the php/php-src was
>>> not such a good idea.
>>
>> Sorry. I made many poor decisions around how I managed that entire event.
>> It’s my own personal Fyre Festival. :-(
>>
>> I’m happy to help in any way I can to get these ready to merge into
>> php-src. Let me know how I can help.
> 
> anyone with access to the php-src git repo should be able to merge them
> pretty easily; it's a matter of running:
> 
> curl -s '
> https://github.com/phpcommunity/phptestfest-php-src/pulls?page=1&q=is%3Apr+is%3Aopen+review%3Aapproved'|grep
> -Po '(?<=<div id="issue_)[0-9]*'|while read id
> do
>    curl
> https://patch-diff.githubusercontent.com/raw/phpcommunity/phptestfest-php-src/pull/$id.patch|git
> am
> done
> 
> and increase the page-number in the first URL to includes pages 2 & 3 as
> well. Run this in your checkout (possibly on a branch) and push that to
> github

It seems to me that the tests should be reviewed (again).  The first one
I've seen[1], should be removed, since it tests general ZPP behavior,
and we're in the process to remove such tests generally[2].

[1]
<https://github.com/phpcommunity/phptestfest-php-src/pull/155/files#diff-33e85609b0c12ee2d4b1c5f6190fdfa4>
[2] <https://github.com/php/php-src/pull/3783>

-- 
Christoph M. Becker