Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:104291
MIME-Version: 1.0
References: <3f5873fe-3fe9-d230-28eb-a20d67550b45@lange.demon.co.uk>
 <CAAfnsFXubTRoyof0E+x+6Q2bBtdpyX6fweAMU6eNfkHS20acdQ@mail.gmail.com> <25859B0A-1633-4FB7-8192-EADBA99A0013@benramsey.com>
In-Reply-To: <25859B0A-1633-4FB7-8192-EADBA99A0013@benramsey.com>
Date: Thu, 7 Feb 2019 16:14:28 +0100
Message-ID: <CAK_tfub70_BuEXETRo=8ZgW+uReHwhKwWwvPuQYAFoSaamaMsA@mail.gmail.com>
To: "internals@lists.php.net" <internals@lists.php.net>
Cc: Peter Kokot <peterkokot@gmail.com>, Ben Ramsey <ben@benramsey.com>, 
	Mark Baker <mark@lange.demon.co.uk>
Content-Type: multipart/alternative; boundary="0000000000001ef52b05814f4d23"
Subject: Re: [PHP-DEV] 2016 TestFest, did the tests written then ever get merged?
From: sjon@hortensius.net (Sjon Hortensius)

--0000000000001ef52b05814f4d23
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 6, 2019 at 4:14 PM Ben Ramsey <ben@benramsey.com> wrote:

> > On Feb 6, 2019, at 01:22, Peter Kokot <peterkokot@gmail.com> wrote:
> > I can help sort this mess. A separate fork out of the php/php-src was
> > not such a good idea.
>
> Sorry. I made many poor decisions around how I managed that entire event.
> It=E2=80=99s my own personal Fyre Festival. :-(
>
> I=E2=80=99m happy to help in any way I can to get these ready to merge in=
to
> php-src. Let me know how I can help.
>
> -Ben
>

anyone with access to the php-src git repo should be able to merge them
pretty easily; it's a matter of running:

curl -s '
https://github.com/phpcommunity/phptestfest-php-src/pulls?page=3D1&q=3Dis%3=
Apr+is%3Aopen+review%3Aapproved'|grep
-Po '(?<=3D<div id=3D"issue_)[0-9]*'|while read id
do
   curl
https://patch-diff.githubusercontent.com/raw/phpcommunity/phptestfest-php-s=
rc/pull/$id.patch|git
am
done

and increase the page-number in the first URL to includes pages 2 & 3 as
well. Run this in your checkout (possibly on a branch) and push that to
github

--0000000000001ef52b05814f4d23--