Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:104284
MIME-Version: 1.0
References: <AM0PR0702MB3684F2B7EFF1826F515BA940E2040@AM0PR0702MB3684.eurprd07.prod.outlook.com>
 <CAF+90c_vvEUYE8_bgPVL0MTJeXik6fYsiueZo644OyZubj74jQ@mail.gmail.com>
 <595b374c-bc4f-9b8a-0013-6485abbfb477@php.net> <CAF+90c8FCMtwRoJEUjBg4XPumzUGFjh0nJa82MFpFFS+WB=rxA@mail.gmail.com>
 <CAG9XoMS2q4uttDpNHPDqSLB78YK1bnS9m7qQE9oTqteGUhTAbA@mail.gmail.com>
 <CALKiJKq9geVL9tLdduPpvGVmT9D8utrQN8oLYy_jqg8hSRhRRw@mail.gmail.com>
 <41D0A782-E4E2-4B98-9C5D-174143DE9A76@gmail.com> <CAG9XoMQY7J6ykjznuAOv06rKR0mDM-JX-dKYLFOt3EnBv3+X3A@mail.gmail.com>
 <CALKiJKpWBFhcbY3CEmykWVgEu0atOfQnV4VbQHzG0MFgG5=qqw@mail.gmail.com>
 <CAG9XoMQt8xNdm3mPUMfJ00ZJHB4UN_j1-uoQTVMMBSKzWW3f_w@mail.gmail.com>
 <d5476721-ead7-11fb-9949-0a9422cd64a1@gmail.com> <CAG9XoMRwREEvwbDrayvTTQMYWKkX1khnj+_2h2qMDDC=4V7G5A@mail.gmail.com>
 <CALKiJKoh7hCiJ_LTAzpzGubab5+pavdEFgzvtqDWT2r42Zda2g@mail.gmail.com> <CAG9XoMQDgW8QCGOdih_UpXC5C8ivOczuM3AN9LHPYLMVRAGANA@mail.gmail.com>
In-Reply-To: <CAG9XoMQDgW8QCGOdih_UpXC5C8ivOczuM3AN9LHPYLMVRAGANA@mail.gmail.com>
Date: Thu, 7 Feb 2019 12:21:13 +0000
Message-ID: <CALKiJKrS+_b76SpptSL6YRqXwtH-myDMKstdrNyPUTvg5Kb-FA@mail.gmail.com>
To: Benjamin Morel <benjamin.morel@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000923e0605814ce17e"
Subject: Re: [PHP-DEV] Re: [RFC] [VOTE] Typed properties v2
From: rowan.collins@gmail.com (Rowan Collins)

--000000000000923e0605814ce17e
Content-Type: text/plain; charset="UTF-8"

On Thu, 7 Feb 2019 at 11:08, Benjamin Morel <benjamin.morel@gmail.com>
wrote:

> Plus, as I stated earlier, I'm confident that typed properties will give
> much more credit to this approach, as we'll get an immediate Error should
> we accidentally access an uninitialized property, as opposed to a null
> value previously.
>

I don't think that solves the fundamental problem, which is that if a
partial object leaks into a wider application context, *correctly written*
code will misbehave. Code that previously ran safely suddenly throwing
exceptions is just as likely to cause serious bugs as code receiving
unexpected nulls, so all the caveats still apply.



>
> I can see that it would be elegant if this function existed, but it seems
>> a thin justification for adding it, when the whole problem could just be
>> approached a different way - e.g.add a property to the model called
>> $_partialFields that stores which fields were initialised.
>
>
> This breaks the separation of concerns: the model should only be concerned
> about business logic, and not contain any persistence-related fields.
>

I think you've already broken encapsulation by forcing the object to be
partial in the first place. Every piece of code interacting with this
object needs to know that it's given a partial, and handle it
appropriately, so it feels unnecessary to pretend that this is still just a
dumb data object to be persisted later.

Regards,
-- 
Rowan Collins
[IMSoP]

--000000000000923e0605814ce17e--