Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:104274
MIME-Version: 1.0
References: <CAF+90c_wZvdgVbmdHH+7J=CLx-rivDRr4vB3=HXK3K2HSNAqMg@mail.gmail.com>
 <CAEZPtU5G9BABiKJnJgOCrRoaaBW-rxE=PmwWL6w2vgm1P5+-rw@mail.gmail.com>
 <CAFPFaMJsOYbD8JxRK6OupenQKn-fWek=b4xZ+407msm7Kv2Vzw@mail.gmail.com> <CAEZPtU71hSzdSk7W7d_A7mbYYFRx0BRGATOdy4CtVX9k0dYwPQ@mail.gmail.com>
In-Reply-To: <CAEZPtU71hSzdSk7W7d_A7mbYYFRx0BRGATOdy4CtVX9k0dYwPQ@mail.gmail.com>
Date: Thu, 7 Feb 2019 10:01:01 +0100
Message-ID: <CAG9XoMQucwxxOFB70YLiSxG3ocTW3ykDu68uBzASeQ-XbE6QMg@mail.gmail.com>
To: Pierre Joye <pierre.php@gmail.com>
Cc: Girgias <george.banyard@gmail.com>, Nikita Popov <nikita.ppv@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000a2386b05814a1547"
Subject: Re: [PHP-DEV] Don't silence fatal errors
From: benjamin.morel@gmail.com (Benjamin Morel)

--000000000000a2386b05814a1547
Content-Type: text/plain; charset="UTF-8"

>
> That is one the cases I meant. Also this is a bug in the user code. I can
> imagine doing it on purpose for performance reasons (if the file is
> created/deleted by other apps) tho'.
>  flock is what should be used here.


flock doesn't protect from other failures, such as a fread()ing a file
located on NFS. As it stands now, @ may still useful to mute warnings and
throw exceptions instead. The other solution today is to set up a temporary
error handler before calling the native function, and restore the previous
error handler right after, such as here
<https://github.com/brick/std/blob/master/src/Internal/ErrorCatcher.php>.
This allows to get the error message, but might incur a small performance
penalty.

IMO, @ can be safely removed the day PHP converts current warnings to
exceptions.





On Thu, 7 Feb 2019 at 02:32, Pierre Joye <pierre.php@gmail.com> wrote:

> On Thu, Feb 7, 2019, 8:07 AM Girgias <george.banyard@gmail.com wrote:
>
> >
> > The most common case which comes to mind is to suppress erros while file
> > reading.
> > Because even if you check a file exists it could be deleted inbetween the
> > check and the
> > read command. As you can see this is even written in the documentation
> [1]
> >
> > Best regards
> >
> > George Peter Banyard
> >
> > [1] https://secure.php.net/manual/en/function.fopen.php
> >
>
> That is one the cases I meant. Also this is a bug in the user code. I can
> imagine doing it on purpose for performance reasons (if the file is
> created/deleted by other apps) tho'.
>  flock is what should be used here.
>
> best,
> Pierre
>
> >
> >
>

--000000000000a2386b05814a1547--