Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:104257
MIME-Version: 1.0
References: <AM0PR0702MB3684F2B7EFF1826F515BA940E2040@AM0PR0702MB3684.eurprd07.prod.outlook.com>
 <CAF+90c_vvEUYE8_bgPVL0MTJeXik6fYsiueZo644OyZubj74jQ@mail.gmail.com>
 <595b374c-bc4f-9b8a-0013-6485abbfb477@php.net> <CAF+90c8FCMtwRoJEUjBg4XPumzUGFjh0nJa82MFpFFS+WB=rxA@mail.gmail.com>
 <CAG9XoMS2q4uttDpNHPDqSLB78YK1bnS9m7qQE9oTqteGUhTAbA@mail.gmail.com>
 <CALKiJKq9geVL9tLdduPpvGVmT9D8utrQN8oLYy_jqg8hSRhRRw@mail.gmail.com>
 <41D0A782-E4E2-4B98-9C5D-174143DE9A76@gmail.com> <CAG9XoMQY7J6ykjznuAOv06rKR0mDM-JX-dKYLFOt3EnBv3+X3A@mail.gmail.com>
In-Reply-To: <CAG9XoMQY7J6ykjznuAOv06rKR0mDM-JX-dKYLFOt3EnBv3+X3A@mail.gmail.com>
Date: Wed, 6 Feb 2019 17:38:01 +0000
Message-ID: <CALKiJKpWBFhcbY3CEmykWVgEu0atOfQnV4VbQHzG0MFgG5=qqw@mail.gmail.com>
To: Benjamin Morel <benjamin.morel@gmail.com>
Cc: Marco Pivetta <ocramius@gmail.com>, Nikita Popov <nikita.ppv@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000b1262505813d308b"
Subject: Re: [PHP-DEV] Re: [RFC] [VOTE] Typed properties v2
From: rowan.collins@gmail.com (Rowan Collins)

--000000000000b1262505813d308b
Content-Type: text/plain; charset="UTF-8"

On Wed, 6 Feb 2019 at 15:21, Benjamin Morel <benjamin.morel@gmail.com>
wrote:

> You're right, in most of the cases properties SHOULD be set by the
> constructor. I do find the current behaviour interesting, however, from a
> data mapper point of view: you might want to retrieve a partial object from
> the database, and get an Error if you accidentally access an uninitialized
> property, as opposed to the pre-typed properties era, where you would get
> null and the "error" would be silenced.
>

The problem with that is, the code doing the partial loading might be
thousands of lines from the code "accidentally" accessing the property. If,
for example, a User class supported partial loading of this sort, any
function that takes a User would have to handle the possibility that what
was actually passed was a partial User. If an error was raised, it would
require tracing back through the code to work out where the conversion from
partial to full object should have happened.

A cleaner implementation would have PartialUser as a different type, which
could not be passed to a function expecting a User; it would then be clear
that a specific code needed to perform a conversion to fetch the rest of
the data, e.g. function getUserFromPartial(PartialUser $partial): User

In other words, if the definition of User includes a non-nullable property
$name, then any object that doesn't have a value for $name is not actually
a User object.

Regards,
-- 
Rowan Collins
[IMSoP]

--000000000000b1262505813d308b--