Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:104225 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 37944 invoked from network); 6 Feb 2019 10:41:15 -0000 Received: from unknown (HELO mail-ot1-f43.google.com) (209.85.210.43) by pb1.pair.com with SMTP; 6 Feb 2019 10:41:15 -0000 Received: by mail-ot1-f43.google.com with SMTP id w25so10220711otm.13 for ; Tue, 05 Feb 2019 23:22:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1kIkcRXlfLo5JZnNH4yXQhoEKD+ca5hs/vVNG8eJ6Oo=; b=G+2KcRB2HJyjpArHcxAm9NIl5Ak9r6ecOUwnAEyJoaqga7rtfGkZDR0lbrm5g8AaYX VXYLnizPdOo2Y9exwRWP0QNwitzW0UKz6uz3oKLmNI3JliIQcYCwb2h94N/CZS0u3RqI 6nXuURasZKOD4DVUEdQJQejAscRgLYLcOhqBnO+bkhkMJvv/E20kUuLIUSJlJTm9x6LK qf8jM9reiD4yDbXGjr6oL7xnTKHpdQN7G1IaAtVUP3QGJvW7UQoMsP6kMy2Ck2I7014A GWJ/UbtkH/Q9/XPQjQelNBeK1hDervsqAeL+Vj/tz6FjW8elRTfw3zf3ydKMAIJGaOqn OuEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1kIkcRXlfLo5JZnNH4yXQhoEKD+ca5hs/vVNG8eJ6Oo=; b=L5a6e2vUpdH1dMzZcMT9TmAfKxrPAvZmGJ99ZzAYdqTAUfaLlI4E92a4Mit2Q2Th5w sDiFmHSKcQToPCGAWPBReHEigfy0kVXs93YOc5QvuSzvEwc3cU0zTU0FMgcI4uRETPdI Nq8CW2uczZzZLX05L9k239L5f1C+qF5cRjxWHhbl6G4+inj3hdL6Mma17P/In/KK2obM oGTENK9g20MFWFBsYvi4m8dzrEDy8r4i90RYu9LrOxTGw1yOGiGnYnyBLGM4fLcjjs2U cVVAJx8ughTphFYkoQ2RyAWKebJV7YYIyI//k/RCq2rpXxc6wcY+Hs09lutzrii1NUql 1Jkg== X-Gm-Message-State: AHQUAuZw7gvnz4SP3ZN7AIRhCIgEEjXynCzYuzNMP4IIo23NFPF6CKTd odSa/L4L3zE68/gQfUt5FDSP2T/t3uB5RuLYmNI7L2GwYIE= X-Google-Smtp-Source: AHgI3Ia47UJZBGcGyEwQAk+B4ovXyhT0FkqGIY9is2At5DwNkzLG8//7h9yf1t8S/q7rzaJb/l4Ejow65Ns+3L3Pcg0= X-Received: by 2002:a9d:6050:: with SMTP id v16mr4818721otj.42.1549437754998; Tue, 05 Feb 2019 23:22:34 -0800 (PST) MIME-Version: 1.0 References: <3f5873fe-3fe9-d230-28eb-a20d67550b45@lange.demon.co.uk> In-Reply-To: <3f5873fe-3fe9-d230-28eb-a20d67550b45@lange.demon.co.uk> Date: Wed, 6 Feb 2019 08:22:22 +0100 Message-ID: To: Mark Baker Cc: "internals@lists.php.net" Content-Type: text/plain; charset="UTF-8" Subject: Re: [PHP-DEV] 2016 TestFest, did the tests written then ever get merged? From: peterkokot@gmail.com (Peter Kokot) Hello, On Wed, 6 Feb 2019 at 08:13, Mark Baker wrote: > > Looking at the Voting Eligibility discussion going on at the moment. > > I, like many others, participated in the last testfest 18 months or so > ago. Did the results from that ever get merged? Or have they simply been > discarded or forgotten? If merged, they certainly don't show up in the > contributions list posted aganst the Workflow and Voting RFC Eligibility > list: yet all those who participated in the testfest care about the > language enough to get involved No, they didn't. And longer we wait more file differences and "merge" conflicts will happen. I'd suggest to start adding one by one those that are accepted and confirmed [1]. I can help sort this mess. A separate fork out of the php/php-src was not such a good idea. Important thing is also that the author is recognised in the commit log properly and credits section is added as a recognition for the volunteers (as noted in the php test fest instructions and all). Let me know when we start adding those. Have a nice day. [1] https://github.com/phpcommunity/phptestfest-php-src/pulls -- Peter Kokot