Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:104179 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 43138 invoked from network); 5 Feb 2019 16:56:34 -0000 Received: from unknown (HELO mail-ua1-f54.google.com) (209.85.222.54) by pb1.pair.com with SMTP; 5 Feb 2019 16:56:34 -0000 Received: by mail-ua1-f54.google.com with SMTP id d19so1096320uaq.11 for ; Tue, 05 Feb 2019 05:37:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pIDAGm5cqmk5M5yZ0zizeZnCc8PxpeTFUGmWFXfMV+g=; b=p4rmyE2S07pNM2Ihk7Tv+th4KbzuofuCGDDku3EVSvtDFgKiOxqORrP2mS021myOmJ VxdIjyJUvsiYNg4MjAxdG3XuEkAzRqhxranElCGH8ZJT3lE7jMKMt5oEzYAt0B1psw4i qwt0mRzmsdYtKZhnKbsv4VIHfEJJjZan845hhnJwWH9o6Mlz5WFLKWVVwUMEgGT7Xxgj TfQ0ztTAZOjz0YfuMqxTYGSvLM6haKNfJdS9sLR0TxAmeDH/JYHcYaRcioOsiUr5Pzi2 Dmb9bLuRzOqnfMo75XZy0lzOh31X3SBlwusN4xPDxm1vtCC7bSx766NNG4Muf/e1PEbA g1Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pIDAGm5cqmk5M5yZ0zizeZnCc8PxpeTFUGmWFXfMV+g=; b=UZaUYLZZZB0HmszJ9el7UJoZTBEyRqXrot1yaixuv+u2mAMzNG1DEsa8a+cTN96cXd D1RXs5ZaJaNMQMh3iOgFS8HC7sumun8ERsqok6PchC1n1iYRCJjfF2DDMUfc/4oI6bmD aDOdMOQ6Orw1jdTdIAGqo098RIbpaI5sZ6AeBfTU1cs3QKHEYuLyxoX5L+Jn3VzzWQFi MGv84FgKpgL5j4UD85l1EbW8JYTRWSMA+PglP+0nF+lNEdkSU3j0Q9XBulf1LZ0tuhQq AUj6dJ4cPUowC0A2zLI/qQdCGAoxkW8vKjA5FqdBgCRBurivgYb1+TOivTwSCrmTTHMW T25Q== X-Gm-Message-State: AHQUAuZQ2bmf+ry5hp+RssCGWK0f5KJI50koRoxcskmOk6hZ21MYeFpe 9PK/ysc17+pfy6QIKRyOuVSf/N4F4G5P/q9QOw4= X-Google-Smtp-Source: AHgI3IaeeiI6Tc7wPTdcTCF9Aoq+ZE9XJBKNPeIIyb7pESjZY4zFSLbJ5SHYkXg5ocMerHV6DErDCmnSsU1WrCwQF1w= X-Received: by 2002:ab0:20d8:: with SMTP id z24mr2001591ual.26.1549373862844; Tue, 05 Feb 2019 05:37:42 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: Date: Tue, 5 Feb 2019 14:37:27 +0100 Message-ID: To: Nikita Popov Cc: PHP internals Content-Type: multipart/alternative; boundary="000000000000b81f39058125b60e" Subject: Re: [PHP-DEV] [RFC] Consistent type errors for internal functions From: george.banyard@gmail.com (Girgias) --000000000000b81f39058125b60e Content-Type: text/plain; charset="UTF-8" On Tue, 5 Feb 2019 at 14:29, Nikita Popov wrote: > On Tue, Feb 5, 2019 at 1:23 PM Girgias wrote: > >> On Tue, 5 Feb 2019 at 12:22, Nikita Popov wrote: >> >>> [. . .] >>> >> >> I'm all for it but what is the scope of the RFC? >> Is it all core functions, bundled extension functions, or all extension >> functions? >> > > It affects all internal functions using the zpp APIs, which covers pretty > much all core functions, bundled extension functions and third-party > extension functions. > Thanks for the clarification, that's great Also does this means that there will be argument type hinting in core >> functions that >> could be found out via reflection? >> > > Not as a direct result of the proposal, but the RFC does remove the big > blocker for it. Once it lands we need one more change (don't actually > verify arginfo types for internal functions to avoid double type checking), > and then we can start adding the necessary type information. That will also > take some work, as we have many functions, but it's something everyone can > help with. > > Nikita > I suppose if this RFC gets voted (and implemented) there should be enough (maybe I'm wrong) time to also implement this. Really like this RFC even with the potential BC break as there are Static analysis tools (such as PHPStan, Psalm and forgot the third major one) which can help point out potential type errors. Best regards George P. Banyard --000000000000b81f39058125b60e--