Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:104123 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 92856 invoked from network); 4 Feb 2019 18:03:54 -0000 Received: from unknown (HELO mail-it1-f176.google.com) (209.85.166.176) by pb1.pair.com with SMTP; 4 Feb 2019 18:03:54 -0000 Received: by mail-it1-f176.google.com with SMTP id b5so248446iti.2 for ; Mon, 04 Feb 2019 06:44:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ea07XaDZBO7JQnzdTTFftoWq07IUlG5QMek21zyyRa4=; b=I1DrAHEGItGFVhhkrZtYrLp9VuBn1AKz5p/2+rs68uzakiIiyi/Us8QJd20UX+CAvF lC9FrcTx5NCyLH3qkI3kWg53vN83Q3mzdwN+GYv5BM7MPVvyM5v516qTw80zgv/o7mXD qqSdMO5CjIl4K/cZbiIKzjQ0yC1/PssSzGM8+2R83wZMDHoO6CdmqKbLdIlyj2tUhh1l DKuCG6AWmy1UXR9OOC8t25LBXFdsX96fkKlQcaBqGFKQNaV427bCo+rBMHK1rlkrmGth KFYmEwBZ8BbMKvPpToK2FKbWg6MVonHmfggGbH5Is3YXmEzGak8MOcXNw2Jzw/POYlcF tdlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ea07XaDZBO7JQnzdTTFftoWq07IUlG5QMek21zyyRa4=; b=G9FTEklrIrvTTReMYX6E7Yf/JK1FGPqgjCGFhZ5lPbqgFhwT9QZnMQtw5gJ7AJRFVy 81zuWK47TruGW2GflseBdPzjP3ZksP6fTDu7QJwtaP50m9SZAA4IWRimnWnx+DwVHS/L Tk4+KiSq4bsZQSdxyB5TMAsvWItFqb5pU9TQ5gHJ2W8QVvmS5pnCAcFoZ4sDEjyjCnmy rdH/cMsYXFbInl/3KpH4kjWxf9nWxDeh6lxjbCL9UJctpI2nmYSrTEr/9+tL19jxiEhk bsy5Qxzt6N06VxCwJVDvBMbGTapdc87JKH4UKzXn8AIqUwPcPUa1Rpd7sqpkFVv6CSSr B6GQ== X-Gm-Message-State: AJcUukenYN33BkvMJbx2HYdFAwTgQ78j327FljLuReN7EO/RKMAQ43vO GkZxsLUURlcxFKyfFNJc2fv1SWgeZeLzHOxrfic= X-Google-Smtp-Source: ALg8bN5X15aluaoynhvE45gnRsOgYhtlwzuGKTwgkFvCEi1jsleamGdxmAf5XKeUouSXjpCHlhWAPZWzXDdcuCgBflI= X-Received: by 2002:a02:8244:: with SMTP id q4mr32081684jag.43.1549291488534; Mon, 04 Feb 2019 06:44:48 -0800 (PST) MIME-Version: 1.0 References: <866a9262-4f49-fa20-e9d2-dcf2f4b0d320@zend.com> <6fda2b56-b99d-d383-af4d-24280767096e@zend.com> In-Reply-To: <6fda2b56-b99d-d383-af4d-24280767096e@zend.com> Date: Mon, 4 Feb 2019 15:44:31 +0100 Message-ID: To: Dmitry Stogov Cc: PHP internals Content-Type: multipart/alternative; boundary="000000000000d409600581128850" Subject: Re: [PHP-DEV] [RFC] JIT From: nikita.ppv@gmail.com (Nikita Popov) --000000000000d409600581128850 Content-Type: text/plain; charset="UTF-8" On Mon, Feb 4, 2019 at 2:26 PM Dmitry Stogov wrote: > > > On 2/1/19 4:23 PM, Dmitry Stogov wrote: > > > > > > On 2/1/19 3:09 PM, Nikita Popov wrote: > >> On Thu, Jan 31, 2019 at 10:44 AM Dmitry Stogov >> > wrote: > >> > >> Hi Internals, > >> > >> > >> I'm glad to finally propose including JIT into PHP. > >> > >> > >> https://wiki.php.net/rfc/jit > >> > >> > >> In the current state it may be included both into PHP-8, where we > >> are going to continue active improvement, and into PHP-7.4, as an > >> experimental feature. > >> > >> > >> Thanks. Dmitry. > >> > >> > >> I would like to check if the JIT provides an improvement for PHP-Parser. > >> Unfortunately I'm getting a segfault when running the tests. Should be > >> reproducible with > >> > >> git clone git@github.com:nikic/PHP-Parser.git > >> cd PHP-Parser > >> composer install > >> php-jit vendor/bin/phpunit > >> > >> I tried to debug this. Unfortunately my gdb doesn't seem to work with > >> JIT: It hangs when the script starts running, on line Zend/zend_gdb.c:84 > >> in zend_gdb_register_code. I don't know if that's a bug or I need to do > >> something additional here (I'm using GNU gdb (Ubuntu 8.1-0ubuntu3) > >> 8.1.0.20180409-git). > > > > GDB takes enormous time registering too many JIT-ed functions... > > It should be possible to catch the name of problematic functions and the > > JIT only them (using PHPDOC trigger). I'll try to analyze the crash, but > > most probably, only on next week. > > I fixed the problem caused JIT to fail on PHP-Parser tests (it was > related to changes introduced by typed properties patch). > > I'm also going to disable automatic JIT code registration in GDB. > > Thanks. Dmitry. > Thanks. I was now able to run a PHP-Parser benchmark, which showed ~1.5x speedup with default JIT configuration. That's promising :) Next I want to try https://github.com/amphp/hpack (part of HTTP 2 implementation), where I also expect good results. Currently there is a segfault while running tests. Nikita --000000000000d409600581128850--