Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:104115
Return-Path: <george.banyard@gmail.com>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 49637 invoked from network); 4 Feb 2019 15:28:44 -0000
Received: from unknown (HELO mail-ua1-f45.google.com) (209.85.222.45)
  by pb1.pair.com with SMTP; 4 Feb 2019 15:28:44 -0000
Received: by mail-ua1-f45.google.com with SMTP id u19so4367427uae.4
        for <internals@lists.php.net>; Mon, 04 Feb 2019 04:09:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=T1+gRtzhpTjHYJOe2jYvHLlumgOesuUJWmjnfLXT2Xw=;
        b=K4WIwWBGtm4PbaZZWtMvechZOkFyAsYhgDuTifWH6rtrJQbP2H22TZs02SwMkhmrhc
         jrlE0oy2txZg/ZJ3Mrsi1xsOIulZuYuonckAIO5UjG9ZFXt+A9kf4P+VlIh+dFXPmPFZ
         Dr3mXredBkBLIp//qNSllOdYH71qb1TJ7Lh26ctdtOw4iw+Nh+H+aIKCtY1p3cbpM7FC
         +xLIE/rYCPs4Noxxnp6DCYgEdjAx0q3SdxCUbCso45xbXgSF6D2TkZq0v1UCgxuHZjwo
         0tckKCvVCfhcH26n4jIsJY3YQjiASmuBOU4TQsJnqJR5JdrNOK/rfnquL7y8IEsqgZUw
         ABHA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=T1+gRtzhpTjHYJOe2jYvHLlumgOesuUJWmjnfLXT2Xw=;
        b=cNHsdPfpZop8O9jy9EolcPDsDFFg0JoUGCR0rv0GVksYR/TiUeLaqQ7u8h0YAl7MgS
         0hOoS2LW+fqOfrgADOTeWGWTT3e5sGBDicy0PEzoaMnWbNpI8+t5Rlvthiy+iUS0WFka
         tsIzKm/biStZrNHrGn4kk8DISw91DhULyNOa9El2STKWtT5K1k/StPji8AY6XPsuCsLE
         sW3oZ+dDHfO+yt/xzvTizmicALBGVToYTgHxPRB2aRbNZmn8cEq7J02G0yiOhc//G286
         zGjZmv28S4ku7r5s7+hH3ZT2xXVzWfg978S3SXRWHYC2fY4YqQpMFXlvBeBtQiRsQjpE
         w/5g==
X-Gm-Message-State: AJcUukeAfgRXyg35FSwGAhSf4S4qowZHQHQ+a8Tpc7uMesgCWJSuWBph
	MFaACqySQwfuseUefbl/OnKgssNsx05WSl6DBzo=
X-Google-Smtp-Source: ALg8bN6uLawwiWfADGDbV/n+Jx4qLAXE3oeuyrgqScYj4VS1by6mDj/SKEvFPTaAvfkfRgfQBU8bm6x1bR57rQYKMtc=
X-Received: by 2002:a9f:314c:: with SMTP id n12mr22486274uab.33.1549282177204;
 Mon, 04 Feb 2019 04:09:37 -0800 (PST)
MIME-Version: 1.0
References: <CAOv67gv0vg=C8hMOiqL_+N=FrD=y1U3XP3v1ocbf+PHO0Ru+Ow@mail.gmail.com>
 <B6A4746E-873B-4084-8E4C-B1796CC58460@gmail.com> <CAOv67guJw8E3eWe6aoLchQGZ4Mb5iYptobqO=T=oSJ+WYKo-9g@mail.gmail.com>
 <CAFPFaMKrSGKJ7mwENrEjTy88ReD9KGbcraPtLyy=7DOVPQU4Wg@mail.gmail.com>
 <CAOv67gsEaGgXiqZzKhE9537JTrcq9QQJ7oqQEEwrKr3Ri0zyXw@mail.gmail.com>
 <CAFPFaMLCY3+ms7Sp5ieMfxdpKu53DHrPS2TAG++Y2OrJ=d8K2Q@mail.gmail.com> <CAOv67gsMumFudk1EgjkR+iPv1X227NMEmKCC2o2HHAv28BxdFw@mail.gmail.com>
In-Reply-To: <CAOv67gsMumFudk1EgjkR+iPv1X227NMEmKCC2o2HHAv28BxdFw@mail.gmail.com>
Date: Mon, 4 Feb 2019 13:09:24 +0100
Message-ID: <CAFPFaM+dmeuYZFnXNFQzs0nK02Wg_GM=m+hWF5ZwstmD4mRVEA@mail.gmail.com>
To: Wes <netmo.php@gmail.com>
Cc: Claude Pache <claude.pache@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d446970581105dc6"
Subject: Re: [PHP-DEV][RFC] Allow void return type variance
From: george.banyard@gmail.com (Girgias)

--000000000000d446970581105dc6
Content-Type: text/plain; charset="UTF-8"

I know this, I am talking about this RFC
https://wiki.php.net/rfc/covariant-returns-and-contravariant-parameters
Which has been voted and implementation is being worked on a GitHub PR:
https://github.com/php/php-src/pull/3732

Your proposal doesn't bring anything new to the table that this RFC does.
Moreover, your RFC targets the same PHP version as the
covariant/contravariant RFC.

So like said before the issue which your RFC tries to address is already
being fixed.

Also, there is no need to upgrade to PHPUnit 8 and if people want to there
is a PHP_CS_FIXER sniff which can add void return types.
Namely: void_return

George P. Banyard


On Mon, 4 Feb 2019 at 13:03, Wes <netmo.php@gmail.com> wrote:

> Covariance from no-type is already supported, since 7.0
> https://3v4l.org/I1hZs
>

--000000000000d446970581105dc6--