Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:104111 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 38409 invoked from network); 4 Feb 2019 14:59:02 -0000 Received: from unknown (HELO mail-vs1-f43.google.com) (209.85.217.43) by pb1.pair.com with SMTP; 4 Feb 2019 14:59:02 -0000 Received: by mail-vs1-f43.google.com with SMTP id z3so8267001vsf.7 for ; Mon, 04 Feb 2019 03:39:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3qM4f7tJcjwWRQCYTAVFNWXi5SxPy+Yp0BYSu10mHLI=; b=JSeQ29VuHkM/jHay9rYLRqHdIyLerVJWi5k1vGOZJl44qrRWx9o4FzTP3AgQiDtlJo aDxdlzjMCr5cqYfEQyQ0fNuQM34MnZY2r2Evwc4B2CFgbCBRZknrs3jEa1CG40nKkcPy IV6rkms39FXELac6SDDjgYqIq9S99RqJyDVe0gcjc5FPzCAGqCUn5w1CaCoT05/7uoF+ MTGiCTddyt32oenBmslOh9k092dtJhWKwZZaQB/OQ7/wdx5sD49Gq1ynKFTurgCv2KAr Xdm2X7vKLWsYbyQ4cuWiMrguTi4GLxB5vckQprWw4z1Owpr5FSOccPwd6eBdNws6AcTe TbbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3qM4f7tJcjwWRQCYTAVFNWXi5SxPy+Yp0BYSu10mHLI=; b=qSOVYccdYUyjJ0hp9e2u+YgLW0NefvGdshHWTGPbhIAndyA+IdiiLSYBcQNrRcNLto vfrwbIiceiux2DxD12NkYfEqxLmTuEaCJtKfFsLT3Jvnu55WCqa6fXlz6QmMA832ub8Q PiO5hCteT0b2P4r/6cbisvnMLrKydi5tO4wZ7ENsyjYqXbyTn1706mnoQIphZDSPvN/t 52yVUN/TSIitXVVrSybeLfK/8xwB8QKx272z7ZImFa4X2RmBgpDPztUw6dE+I7pVU0z6 Zg1dHu79ANFpRD9X5sD+ClghvYy+58oAPCM8wYrJjQausysKSK9DAepE68uN9sclRHtP zKow== X-Gm-Message-State: AJcUuke9JroFh85YNWCDweifLUyMNgE8wBLZam0/EfPKnAQFBhcGR0bI xxX88DHpE1Zf063QKVgTjunZJevIYbM1qXjZYEA= X-Google-Smtp-Source: ALg8bN6dvVB18VqpaaOfHbfw2KMQPUfRUJKNhMMmbaGKVbetYF/ajXKyeRzd+OUlLXRwWLbD/dqqfkYCx5TXqKvavUQ= X-Received: by 2002:a67:6d42:: with SMTP id i63mr22684846vsc.158.1549280394596; Mon, 04 Feb 2019 03:39:54 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: Date: Mon, 4 Feb 2019 12:39:41 +0100 Message-ID: To: Wes Cc: Claude Pache , PHP Internals Content-Type: multipart/alternative; boundary="00000000000093d62a05810ff322" Subject: Re: [PHP-DEV][RFC] Allow void return type variance From: george.banyard@gmail.com (Girgias) --00000000000093d62a05810ff322 Content-Type: text/plain; charset="UTF-8" Isn't this "fixed" with the Covariance/Contravariance RFC which has been voted recently George P. Banyard On Mon, 4 Feb 2019 at 08:58, Wes wrote: > Hi! > > PHPUnit 8 changed e.g. ` function setUp(){}` to ` function setUp(): > void{} ` and a lot of people did not like being forced to do the same on > their `setUp()`. > > The issue is not PHPUnit adding `void`, but PHP forcing `void` even when > it's not necessary. If PHPUnit wants to use void but inheritors don't want > to, it should just be possible. > > "probably a bad idea" is opinionated, in reality there is no provable > reason to disallow it, from a pure type-theory standpoint. > --00000000000093d62a05810ff322--