Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:10402
Return-Path: <valyala@tut.by>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 40033 invoked by uid 1010); 11 Jun 2004 14:51:05 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 39805 invoked by uid 1007); 11 Jun 2004 14:51:04 -0000
To: internals@lists.php.net
Date: Fri, 11 Jun 2004 17:50:16 +0300
Organization: none
Content-Type: text/plain; format=flowed; delsp=yes; charset=koi8-r
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Message-ID: <opr9fp52jwt8r34v@valyala>
User-Agent: Opera M2/7.50 (Win32, build 3778)
X-Posted-By: 217.23.116.150
Subject: str_repeat() patch
From: valyala@tut.by ("Alexander Valyalkin")


Read it:
void *memmove(void *s1, const void *s2, size_t n);
If s1 and s2 overlap, all bytes are copied in a preserving manner (unlike  
memcpy())

And anwer the question: are s1 and s2 overlap in the str_repeat() ?
Why don't use memcpy() instead of memmove() ?

===========cut=============
--- string.c    Thu May 13 20:44:32 2004
+++ string_str_repeat.c Fri Jun 11 17:40:47 2004
@@ -3581,7 +3581,7 @@

         while (e<ee) {
             l = (e-s) < (ee-e) ? (e-s) : (ee-e);
-           memmove(e, s, l);
+            memcpy(e, s, l);
             e += l;
         }
     }

===========cut=============

-- 
Using Opera's revolutionary e-mail client: http://www.opera.com/m2/