Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103983
MIME-Version: 1.0
References: <DM6PR02MB59326E10841277F34E4EFF75BF910@DM6PR02MB5932.namprd02.prod.outlook.com>
 <CAF+90c_LzxUTcsbdKGiJFjp=z84jLMFzq_JReXjsNygsBDVoYw@mail.gmail.com>
In-Reply-To: <CAF+90c_LzxUTcsbdKGiJFjp=z84jLMFzq_JReXjsNygsBDVoYw@mail.gmail.com>
Date: Fri, 1 Feb 2019 13:31:58 +0100
Message-ID: <CAF+90c8hO7CHRfHonKM1wpoCmLNoGr1a=93yZK0_EfYfaV1WjQ@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000040fbea0580d45543"
Subject: Re: [PHP-DEV] [RFC] JIT
From: nikita.ppv@gmail.com (Nikita Popov)

--00000000000040fbea0580d45543
Content-Type: text/plain; charset="UTF-8"

On Fri, Feb 1, 2019 at 1:09 PM Nikita Popov <nikita.ppv@gmail.com> wrote:

> On Thu, Jan 31, 2019 at 10:44 AM Dmitry Stogov <dmitry@zend.com> wrote:
>
>> Hi Internals,
>>
>>
>> I'm glad to finally propose including JIT into PHP.
>>
>>
>> https://wiki.php.net/rfc/jit
>>
>>
>> In the current state it may be included both into PHP-8, where we are
>> going to continue active improvement, and into PHP-7.4, as an experimental
>> feature.
>>
>>
>> Thanks. Dmitry.
>>
>
> I would like to check if the JIT provides an improvement for PHP-Parser.
> Unfortunately I'm getting a segfault when running the tests. Should be
> reproducible with
>
> git clone git@github.com:nikic/PHP-Parser.git
> cd PHP-Parser
> composer install
> php-jit vendor/bin/phpunit
>
> I tried to debug this. Unfortunately my gdb doesn't seem to work with JIT:
> It hangs when the script starts running, on line Zend/zend_gdb.c:84 in
> zend_gdb_register_code. I don't know if that's a bug or I need to do
> something additional here (I'm using GNU gdb (Ubuntu 8.1-0ubuntu3)
> 8.1.0.20180409-git).
>
> Nikita
>

Another project that I would like to test is amp
(git@github.com:amphp/amp.git).
Here I am getting a segfault only on shutdown, after tests finished
running. However there are a number of test failures, all basically looking
the same:

1) Amp\Test\AllTest::testPendingPromiseArray
TypeError: Return value of Amp\Loop\Internal\TimerQueue::removeAndRebuild()
must be an instance of Amp\Loop\Internal\TimerQueueEntry, null returned

/home/nikic/amp/lib/Loop/Internal/TimerQueue.php:100
/home/nikic/amp/lib/Loop/Internal/TimerQueue.php:64
/home/nikic/amp/lib/Loop/NativeDriver.php:107
/home/nikic/amp/lib/Loop/Driver.php:134
/home/nikic/amp/lib/Loop/Driver.php:72
/home/nikic/amp/lib/Loop.php:84
/home/nikic/amp/test/AllTest.php:52

Here is the line that incorrectly gets a null:
https://github.com/amphp/amp/blob/c6f8425473ecc1cfc6909cf42b39abb39a11c837/lib/Loop/Internal/TimerQueue.php#L100

Nikita

--00000000000040fbea0580d45543--