Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:103900 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 85069 invoked from network); 30 Jan 2019 22:00:08 -0000 Received: from unknown (HELO mail-pg1-f179.google.com) (209.85.215.179) by pb1.pair.com with SMTP; 30 Jan 2019 22:00:08 -0000 Received: by mail-pg1-f179.google.com with SMTP id z11so211275pgu.0 for ; Wed, 30 Jan 2019 10:39:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4VBTLWLpAgXSTmZ3xmAzYMXjATSJote9+F1GgHwyudI=; b=fKU7GwucwBVWnlN3WV2qkK9EQv/KKGPKQF8uESld1pUvbZg6g/QOgaRgDIbvU94yvd lmLmvk5UyJHbCjKs/Afn9SvbTqUwz2slwc0EmwpBhrTC+6CQpCf/R4VorJsDB98wiB4S uR7GqdcKHVX7h+UlRi734f6oqI2+VamJoltOrLIGz81JflAapDdt2J8dRlJxMfOQwwfe K8Bpb15MIEr5okLHZfoxH6q8XzGnN3GicJv2LixfcmsoGzsfyTXWNKniorCnoYqmDAQ9 cdd1uBwwXbQEoxWffYh1htmHZO74uYUiw37qg/9D9NouTI5+EboccN3jmT01ZfI8wqFD fpzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=4VBTLWLpAgXSTmZ3xmAzYMXjATSJote9+F1GgHwyudI=; b=KjiMRTyMImdcnMkZXijtFDOCt4fEeOnHNDcKsSbpQqR4IWAADbmp8/ZjYFS5aQ3Hj0 BI5IVk4Ka6hKIDWbfzSKuF21hPZ6zeCbCofy0FgApHRni6RIKQrg+DZO2ILjLCMMBikI Ez36Mc3woHSjrsFbeRWnDZCSNEn7qZYou2Xx5P252IcGS8P1if9FdbmRZAEsLXDZHbCT RhaftvRESKZHzNRZ5TSvhWAUpzs4ZqTFNaRvKdl3kT6VZjYhuk8q6p89Tx0gNI3P0SwV 8vc4o66YMKeayTIQKo6bkzqrzgc6zun0P8p6n2htg/7VXA1SDkVQX/XpNMDFmS8PiUjm LNLw== X-Gm-Message-State: AJcUukd0g5/BKZeimxBhnHqhEpt9UJlL8FBmGmeo7R0RSjL0j4Kgruy2 ik0fKN/Qn+Xg7iugdMDjgV9r30w= X-Google-Smtp-Source: ALg8bN6RQ7xfL1IDpDhaDU32olon3t6sSDwDYB38fnYjFKrMGQZ+ALbhnjOpzb56RvbmTJ6I2MRepA== X-Received: by 2002:a62:ab0d:: with SMTP id p13mr31625732pff.211.1548873587791; Wed, 30 Jan 2019 10:39:47 -0800 (PST) Received: from Stas-Pro-2016.local ([12.97.215.254]) by smtp.gmail.com with ESMTPSA id 78sm3242507pft.184.2019.01.30.10.39.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Jan 2019 10:39:46 -0800 (PST) To: Nikita Popov , PHP internals References: Openpgp: preference=signencrypt Autocrypt: addr=smalyshev@gmail.com; prefer-encrypt=mutual; keydata= mQMuBE9mqaARCACFSqcGmNunkjQQu3X+yXnTmFeEkvM4JXZTOBdR8aEevNGmmFEfyvjaDjWi 9hcwp4E/lYtC+P7VsVjM1OSX9eq0jC/lGL0ZyRXek+mNy0n5H1NSuTpf9Y18LMqhc4G+RU+L cNiZ9K0DJuOOvNLPxW7OHZguxb3wdKPXNVa2jyRfJAKm2uaJJMT1mTmFT9a0Q8SKr+mUrrJk uG0H2o6SzrKt8Wwoint1eh67zVsJaJtQFchnEZnlawIcqP2yC4nLGR3MkubowxoEBYCZet18 aHVVRbvpG2Qtob8Lu5xrsGbmXymTkHTdpvkfcJFADa8MzOL90zOxXwbGfbIZOlh5En8jAQCX lfnx2eQL3BSW/6XANa51dbWiEp1d1BAkpGKtZvlk0Qf+M9WAi+9aXMe3xP5krxtgnRNUf2WN 6Zdy2MxL1RRJCFbytLhl0ronC49BsGYVGshdEH8xhBbiIOJKuVZ/DTl9bEm7P9c7CC7iJyVC khUAhouH6xzZQNLR+RU+QebYzXypVfl99Qk7EdMmr/WAZCHLuvanyqepC5EBsa3VnAfQemSN oBeGBKWWLiOsPjvS72+y1z4RUMAfXHn4l/sFMt8zt7/74AmJPwZquV41p4mPO12V4+xPyc6R sB84sfsk2QVivU8w8AkvGQeYjXoz7Iwao95+fWteVzZ36KRQvUckP8pGjHlDXnHxJ0HI1I/k OBZSjwRwUf0dd73y6erPhbLk+gf+NdI3H9KGJBzG5/rVyWKwUeQ9d5ud4jTJRkQGvAP5pg76 vEa9dogbpe4W5Z+0BfbiJSnQmQWSHiZddj/t33ptbup44Ck6ZTgdlmFYMLF1hR47PIZTDKER EuKYGci/vq8snZvEJP9YCw/TtiHcMdrMKcY/+Lp8lQO0GHLPB9glVhnC0db6l1Xpg1CMI8/R ozBMcij30EgATggC/y2zbiqAFoS9FN9nXPbe4phStqABEyeZ+nXudt7PUYTjVgcrqo8bHZCi sBobWC7OnKyUzxVxzUeuPkIfmZuzkLaMw2McQdvwwsNvQ0DzaLP30c1Xsm/7EIYJcOWpzlVJ 5QrdmE0/BbQyU3RhbmlzbGF2IE1hbHlzaGV2IChQSFAga2V5KSA8c21hbHlzaGV2QGdtYWls LmNvbT6IegQTEQgAIgUCT2aqtAIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQL3lW vF2gS12XMwD9HuRIolSwIK77u8EY461y2u6sbX36n5/uo/LDQuxoi3sA/0MvpnvzOhv9Iufv vsZEj3E7i3h+iD5648YMwfTFCij+uQINBE9mqaAQCADfZPMpjZkkGZj3BY/7ApoLq4mwqzbh +CpLXwNn20tFNvSXfb8RdeXvVEb7Scx+W9qYpiaun2iXJgCVH8fgpZpR856ulT1q6uCG++CX ubEvip/eJkZl93/84h04KQJwsgOrAh0Om3OePRn8Pr+++0LNS0EL8uX/YHeTOGOnnmTqYTey SBVFdov6L4mepddfjekicKQqhL7mZh/xuq29JijT0uNNX8v4vDWQDu5dlAcdd+uB3gcXMD/P ginD11zp+6wtrWCm/+yBqpvDwXQX5PGUnwvbRfl7Ay3MmwmoXiecZMg0dwTSc7e0lhB4HGRH ZdBMJB4rHUVGdzqujK/ctOvrAAMFB/0Utb76Qe6sCMlHxVAmeE/fbo7Pi05btZ/x01r67dHf aMSP0riCKJ7M0OW+jAXtu9+z/BVnYisW67WWfxl2cS5tZDgiHgJARXWUOO72+sScHP8KQmTl 1z16gyKbwY3SmyBkwcpOL35nhUWNLy93syPoY6sZUTikr2bZYukHDQ33XBPs4e6MbWKfsa9q aVmnlOF3k5UqChjutfHaEa4Q7VP4wBIpphHBi9MI16oJIzzBPbGl2uoedjwiZ6QeQZnSuOVY ZxU2d3lRA8PrtfFN1VSlpEm/VcAvtieHUYWHN0wOu+cp3Slr5XJVNjTjJhl28SlinMME54mK AGf2Ldr/dRwXiGEEGBEIAAkFAk9mqaACGwwACgkQL3lWvF2gS126EQD/VVd3FgjLKglClRQP zdfU847tqDK4zJjbmRv5vLLwoE0A+wbrQs7jVGU3NrS0AIl5vUmewpp2BKzSkepy23nWmejw Message-ID: <04acea66-d42c-7352-85fa-738ea2519ede@gmail.com> Date: Wed, 30 Jan 2019 10:39:45 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Remove zpp variation tests From: smalyshev@gmail.com (Stanislav Malyshev) Hi! > This test passes a certain set of input values of different types to a > function with a zpp string argument and observes the behavior. Of course, > there are also hundreds of other functions that accept strings through zpp > and the behavior is always going to be the same. This is true for functions that use standard zpp handling, but there are a number of them that use custom zpp handling, and for those there could be corner cases which aren't handled properly. In fact, I've seen some zpp-using functions that so not properly handle nulls, empty strings, etc. as arguments (zpp works fine, it's the part past zpp that fails). So we need to be careful and remove only those tests that are indeed handled by zpp and not the code beyond it that does need to be tested, and not remove tests which cover custom argument handling. -- Stas Malyshev smalyshev@gmail.com