Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103891
MIME-Version: 1.0
References: <CAF+90c-KQY2cJWjnkd0_C3HiRqEp-k+whCF35GUQZTxN-1rbhw@mail.gmail.com>
In-Reply-To: <CAF+90c-KQY2cJWjnkd0_C3HiRqEp-k+whCF35GUQZTxN-1rbhw@mail.gmail.com>
Date: Wed, 30 Jan 2019 09:25:47 -0200
Message-ID: <CAP=4hCLKMNQSsGOaA5Ghj4Gd9Hw2gCqboH=SwbMfrEC1WrKeQw@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000009d924d0580ab2c1c"
Subject: Re: [PHP-DEV] Remove zpp variation tests
From: carusogabriel34@gmail.com (Gabriel Caruso)

--0000000000009d924d0580ab2c1c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Em qua, 30 de jan de 2019 =C3=A0s 07:46, Nikita Popov <nikita.ppv@gmail.com=
>
escreveu:

> Hi internals,
>
> We currently have a large number of zpp "variation" tests, which
> essentially only test the behavior of zend_parse_parameters plugged into
> different functions. A random example of such a test:
>
>
> https://github.com/php/php-src/blob/master/ext/standard/tests/strings/add=
slashes_variation1.phpt
>
> This test passes a certain set of input values of different types to a
> function with a zpp string argument and observes the behavior. Of course,
> there are also hundreds of other functions that accept strings through zp=
p
> and the behavior is always going to be the same.
>
> Based on a quick grep I would estimate that we have around 700 of these
> tests. We have a hard policy against adding new tests for zpp behavior, b=
ut
> I would like to get rid of the existing ones as well. They provide
> essentially no value, but are a major chore to update for even for minor
> changes.
>
> Regards,
> Nikita
>

Yes, yes, yes!

When I was implementing the https://github.com/php/php-src/pull/3429, was a
pain fixing all those tests.
--=20
Gabriel Caruso

--0000000000009d924d0580ab2c1c--