Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103886
MIME-Version: 1.0
Date: Wed, 30 Jan 2019 10:45:28 +0100
Message-ID: <CAF+90c-KQY2cJWjnkd0_C3HiRqEp-k+whCF35GUQZTxN-1rbhw@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000250f8e0580a9c6cc"
Subject: Remove zpp variation tests
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000250f8e0580a9c6cc
Content-Type: text/plain; charset="UTF-8"

Hi internals,

We currently have a large number of zpp "variation" tests, which
essentially only test the behavior of zend_parse_parameters plugged into
different functions. A random example of such a test:

https://github.com/php/php-src/blob/master/ext/standard/tests/strings/addslashes_variation1.phpt

This test passes a certain set of input values of different types to a
function with a zpp string argument and observes the behavior. Of course,
there are also hundreds of other functions that accept strings through zpp
and the behavior is always going to be the same.

Based on a quick grep I would estimate that we have around 700 of these
tests. We have a hard policy against adding new tests for zpp behavior, but
I would like to get rid of the existing ones as well. They provide
essentially no value, but are a major chore to update for even for minor
changes.

Regards,
Nikita

--000000000000250f8e0580a9c6cc--