Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103874
Message-ID: <0CA68783-C741-4F86-AC74-CF366CCA9407@gmail.com>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_6BC3E112-9348-4818-8618-D707BBCDC613"
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Date: Tue, 29 Jan 2019 08:38:20 +0100
In-Reply-To: <CAFPFaM+ho3mPrk_Bx4mz8ApFtWwDJYo+pFoOpoJ+L5LZq_oFkA@mail.gmail.com>
Cc: Dan Ackroyd <Danack@basereality.com>,
 Rowan Collins <rowan.collins@gmail.com>,
 Benjamin Morel <benjamin.morel@gmail.com>,
 Thomas Hruska <thruska@cubiclesoft.com>,
 PHP Internals <internals@lists.php.net>
To: Girgias <george.banyard@gmail.com>
References: <CAFPFaM+cEa2xFDqvkLQk=Qht3KdcGUCBaCj6JcuQxqLmjnf9Pw@mail.gmail.com>
 <d43d155f-9fd8-ddff-a44b-3dce2b2f6841@cubiclesoft.com>
 <CAG9XoMTK4j8R6_v++th2wRkdh5GZD4Vd9tKDt9YpXrhYmoH4uA@mail.gmail.com>
 <CAG9XoMRRO0mmfnuYrH5v4eFWOjRea-o0HmwezuWd=HXyOQT6WA@mail.gmail.com>
 <CALKiJKpfGWMav7hUNCA-FmNjyYuMkZx+=NHSHzwx35eEz+Gt3g@mail.gmail.com>
 <CAFPFaMJSKoFv_oSRa6oDJwooXxws_u5-V7wQU6S3AkZinqmv4A@mail.gmail.com>
 <CA+kxMuSNqfAzo+_+DCaChuJ4zny6fOvn46HFsUsnb+DNERVLXA@mail.gmail.com>
 <CAFPFaM+ho3mPrk_Bx4mz8ApFtWwDJYo+pFoOpoJ+L5LZq_oFkA@mail.gmail.com>
Subject: Re: [PHP-DEV] Deprecation ideas for PHP 8
From: claude.pache@gmail.com (Claude Pache)

--Apple-Mail=_6BC3E112-9348-4818-8618-D707BBCDC613
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



>=20
> And then there is *array_multisort* a function which has a signature =
which
> isn't even possible in userland code.
> (https://secure.php.net/manual/en/function.array-multisort.php =
<https://secure.php.net/manual/en/function.array-multisort.php>).
> Other than the fact that this function's documentation isn't totally
> correct in my opinion I did a Github search to see if people use it.
> =46rom what I've seen in the search results [1], around 620k, it is =
only used
> in phpt unit tests and a unit test of a parser.
>=20
> [1]
> =
https://github.com/search?l=3DPHP&o=3Ddesc&p=3D1&q=3Darray_multisort&s=3D&=
type=3DCode =
<https://github.com/search?l=3DPHP&o=3Ddesc&p=3D1&q=3Darray_multisort&s=3D=
&type=3DCode>
>=20

Presumably, if you sort the results by =E2=80=9DBest match=E2=80=9D, =
test units appear first because they are the only occasions where you =
invoke this function ten times in a row. Try to sort by =E2=80=9DRecently =
indexed=E2=80=9D and you=E2=80=99ll get some real usages.

> Now, I don't think a function which doesn't follow normal function
> signature converntion (or isn't even possible) shouldn't really be =
part of
> the language.
> Moreso that it seems barely anybody uses it.
> What's people opinion on deprecating array_multisort ?

One of the most important things to consider when proposing deprecations =
is the migration cost you impose to your users. It is apparently =
something easily forgotten by those that love deprecations : =E2=80=9CIn =
order to make migrating your legacy code even more painful, we have =
carefully chosen to deprecate a function that you=E2=80=99ll have =
trouble to reimplement userland.=E2=80=9D

Moreover, even when assuming (incorrectly) that it is barely used: What =
is the benefit of deprecating array_multisort? (This question is valid =
also for future deprecation proposals.)

=E2=80=94Claude=

--Apple-Mail=_6BC3E112-9348-4818-8618-D707BBCDC613--